From: Bastien <bzg@gnu.org>
To: nicholas.dokos@hp.com
Cc: Bernt Hansen <bernt@norang.ca>,
emacs-orgmode@gnu.org, Eric Schulte <eric.schulte@gmx.com>
Subject: Re: Tangling is broken in git master
Date: Mon, 13 Aug 2012 21:00:04 +0200 [thread overview]
Message-ID: <874no6wrbf.fsf@gnu.org> (raw)
In-Reply-To: <11277.1344872323@alphaville> (Nick Dokos's message of "Mon, 13 Aug 2012 11:38:43 -0400")
Hi Nick,
Nick Dokos <nicholas.dokos@hp.com> writes:
> I'd suggest that that can be a source of bugs that would be
> avoided with a compatibility macro.
`org-labels' is an alias for `cl-labels' (when available) or `labels'.
There is no need for a compatibility macro here, as the current code
is compatible with both Emacs 23 and Emacs 24 -- and hopefully later
versions of Emacs.
The question is rather whether we want to be very strict and replace
as much cl-* constructs as possible.
Nicolas shown a way to let-bind functions recursively (which is simple
and neat, by the way), so yes, I'd favor replacing org-labels in this
case. Especially because the cl-labels and labels macros do not work
exactly the same way.
See labels' docstring:
...
Like `cl-labels' except that the lexical scoping is handled via `lexical-let'
rather than relying on `lexical-binding'.
> But maybe the compatibility macro would be a bigger problem - I don't
> know for sure. In particular, the file would need a periodic cleanup to
> get rid of old cruft, but if it's a once-a-year-or-two occurrence, that
> might not be too bad.
Always good to know there are many people we can rely on to clean the
old cruft :)
--
Bastien
prev parent reply other threads:[~2012-08-13 18:59 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-12 1:03 Tangling is broken in git master Bernt Hansen
2012-08-12 6:27 ` Achim Gratz
2012-08-13 1:57 ` Bernt Hansen
2012-08-12 8:43 ` Bastien
2012-08-13 1:55 ` Bernt Hansen
2012-08-13 5:43 ` Bastien
2012-08-13 13:44 ` Eric Schulte
2012-08-13 13:56 ` Bastien
2012-08-13 14:18 ` Eric Schulte
2012-08-13 14:42 ` Bastien
2012-08-13 15:25 ` Nicolas Goaziou
2012-08-13 19:00 ` Bastien
2012-08-13 14:46 ` Nick Dokos
2012-08-13 14:53 ` Bastien
2012-08-13 15:38 ` Nick Dokos
2012-08-13 19:00 ` Bastien [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874no6wrbf.fsf@gnu.org \
--to=bzg@gnu.org \
--cc=bernt@norang.ca \
--cc=emacs-orgmode@gnu.org \
--cc=eric.schulte@gmx.com \
--cc=nicholas.dokos@hp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).