From: Carsten Dominik <carsten.dominik@gmail.com>
To: Xiao-Yong Jin <jinxiaoyong@gmail.com>
Cc: "emacs-orgmode@gnu.org" <emacs-orgmode@gnu.org>
Subject: Re: default face org-column
Date: Sat, 1 Jun 2013 08:17:41 +0200 [thread overview]
Message-ID: <068396FB-493D-456B-922A-D4638EBE0FA3@gmail.com> (raw)
In-Reply-To: <657A219F-8300-4EDD-98B3-6737014F5EF4@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1937 bytes --]
On 30.5.2013, at 04:43, Xiao-Yong Jin <jinxiaoyong@gmail.com> wrote:
> Hi,
>
> In org-faces.el,
>
> (when (fboundp 'set-face-attribute)
> ;; Make sure that a fixed-width face is used when we have a column table.
> (set-face-attribute 'org-column nil
> :height (face-attribute 'default :height)
> :family (face-attribute 'default :family)))
Hi Xiao,
I remember that I struggled with the problem that I had to make sure that column view used a fixed-width face - and this was the solution that worked - not a particular pretty one, admittedly.
Do you have an idea on how to change this code that it will always work? I'd be very happy to accept a good patch.
- Carsten
>
> I understand why you did this, but it is not quite logical, and somewhat invasive. First, you certainly do not do this with org-table. Then why org-column specifically? Second, it overwrites the the value I set in the emacs theme or custom-set-faces. Third, the end result is quite bizarre and odd-looking. The "default" height and "default" family is some how not what I set for the frame, because the font family and size is set when emacs starts up and loaded the org-mode. When I use set-frame-font or text-scale-adjust, org-column will stick with the old font family and size. In fact, because the font family for org-column and org-column-title are different, the result is just bad.
>
> I don't think it is only my problem, but I'll describe my setup for themes/font. I use default-frame-alist to set the font family and size—The above code will not pick up this setup. I use load-theme and enable-theme to load the theme I want. Sometimes I use set-frame-font or text-scale-adjust to get a pleasantly looking texts temporary. I usually use fixed-width font, so the above code is not doing any good.
>
> For the time being, I commented out the above code.
>
> Best,
> Xiao-Yong
>
[-- Attachment #2: Type: text/html, Size: 3128 bytes --]
next prev parent reply other threads:[~2013-06-01 6:17 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-30 2:43 default face org-column Xiao-Yong Jin
2013-06-01 6:17 ` Carsten Dominik [this message]
2013-06-28 4:55 ` Xiao-Yong Jin
2013-06-28 11:05 ` Carsten Dominik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=068396FB-493D-456B-922A-D4638EBE0FA3@gmail.com \
--to=carsten.dominik@gmail.com \
--cc=emacs-orgmode@gnu.org \
--cc=jinxiaoyong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).