emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed

From: Xiao-Yong Jin <jinxiaoyong@gmail.com>
To: "emacs-orgmode@gnu.org" <emacs-orgmode@gnu.org>
Subject: default face org-column
Date: Thu, 30 May 2013 11:43:01 +0900	[thread overview]
Message-ID: <657A219F-8300-4EDD-98B3-6737014F5EF4@gmail.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 1481 bytes --]

Hi,

In org-faces.el,

(when (fboundp 'set-face-attribute)
  ;; Make sure that a fixed-width face is used when we have a column table.
  (set-face-attribute 'org-column nil
		      :height (face-attribute 'default :height)
		      :family (face-attribute 'default :family)))

I understand why you did this, but it is not quite logical, and somewhat invasive.  First, you certainly do not do this with org-table.  Then why org-column specifically?  Second, it overwrites the the value I set in the emacs theme or custom-set-faces.  Third, the end result is quite bizarre and odd-looking.  The "default" height and "default" family is some how not what I set for the frame, because the font family and size is set when emacs starts up and loaded the org-mode.  When I use set-frame-font or text-scale-adjust, org-column will stick with the old font family and size.  In fact, because the font family for org-column and org-column-title are different, the result is just bad.

I don't think it is only my problem, but I'll describe my setup for themes/font.  I use default-frame-alist to set the font family and size—The above code will not pick up this setup.  I use load-theme and enable-theme to load the theme I want.  Sometimes I use set-frame-font or text-scale-adjust to get a pleasantly looking texts temporary.  I usually use fixed-width font, so the above code is not doing any good.

For the time being, I commented out the above code.

Best,
Xiao-Yong


[-- Attachment #2: Type: text/html, Size: 2143 bytes --]

next             reply	other threads:[~2013-05-30  2:43 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-05-30  2:43 Xiao-Yong Jin [this message]
2013-06-01  6:17 ` default face org-column Carsten Dominik
2013-06-28  4:55   ` Xiao-Yong Jin
2013-06-28 11:05     ` Carsten Dominik

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=657A219F-8300-4EDD-98B3-6737014F5EF4@gmail.com \
    --to=jinxiaoyong@gmail.com \
    --cc=emacs-orgmode@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).