From: Max Nikulin <manikulin@gmail.com>
To: emacs-orgmode@gnu.org
Subject: Re: [BUG] LaTeX preview should use a subdirectory in /tmp
Date: Mon, 25 Mar 2024 19:49:35 +0700 [thread overview]
Message-ID: <utrrt0$g1g$1@ciao.gmane.io> (raw)
In-Reply-To: <87r0fyo7yo.fsf@localhost>
On 25/03/2024 18:40, Ihor Radchenko wrote:
> Max Nikulin writes:
>> This feature should not write temporary files to /tmp directly
>
> See the attached tentative patch.
Thanks for prompt reaction.
> +++ b/lisp/org.el
> @@ -16361,7 +16361,7 @@ (defun org-create-formula-image
> org-format-latex-header
> 'snippet)))
> (latex-compiler (plist-get processing-info :latex-compiler))
> - (tmpdir temporary-file-directory)
> + (tmpdir (concat temporary-file-directory "orgtex/"))
> (texfilebase (make-temp-name
> (expand-file-name "orgtex" tmpdir)))
Since directory name already contains "org", it may be shortened to just
"tex"
> (texfile (concat texfilebase ".tex"))
I would use `make-temp-file' to create TEXFILE and would derive
TEXFILEBASE from it. In general it is safer.
To create directory I expect a call of a function similar to the
following one. Perhaps it exists already somewhere.
(defun org-ensure-tmp-dir (dir-symbol prefix)
(let ((dir (symbol-value dir-symbol)))
;; Temporary directory has not been cleaned.
(or (and dir (file-directory-p dir) dir)
(setf (symbol-value dir-symbol)
(make-temp-file (or prefix "orgtmp-") 'dir)))))
(defvar org-tex-tmpdir nil)
Usage example: (org-ensure-tmp-dir 'org-tex-tmpdir "orgtex-")
Fixed directory name is not friendly for multi-user systems and
predictable name in /tmp might be a source of security issues.
next prev parent reply other threads:[~2024-03-25 12:50 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-25 10:40 [BUG] LaTeX preview should use a subdirectory in /tmp Max Nikulin
2024-03-25 11:40 ` Ihor Radchenko
2024-03-25 12:49 ` Max Nikulin [this message]
2024-03-26 11:29 ` Max Nikulin
-- strict thread matches above, loose matches on Subject: below --
2024-04-17 15:12 copropriete27ruemoret
2024-04-17 15:21 Emmanuel Charpentier
2024-04-17 16:48 ` Ihor Radchenko
2024-04-17 20:04 ` Emmanuel Charpentier
2024-04-17 20:18 ` Ihor Radchenko
2024-04-17 20:41 ` Emmanuel Charpentier
2024-04-18 12:23 ` Emmanuel Charpentier
2024-04-19 11:56 ` Ihor Radchenko
2024-04-19 15:00 ` emm.charpentier
2024-04-20 12:49 ` Max Nikulin
2024-05-02 10:30 ` Ihor Radchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='utrrt0$g1g$1@ciao.gmane.io' \
--to=manikulin@gmail.com \
--cc=emacs-orgmode@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).