From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1.migadu.com ([2001:41d0:303:e224::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms8.migadu.com with LMTPS id 8HIbEylzAWYLGQEA62LTzQ:P1 (envelope-from ) for ; Mon, 25 Mar 2024 13:50:49 +0100 Received: from aspmx1.migadu.com ([2001:41d0:303:e224::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1.migadu.com with LMTPS id 8HIbEylzAWYLGQEA62LTzQ (envelope-from ) for ; Mon, 25 Mar 2024 13:50:49 +0100 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" ARC-Seal: i=1; s=key1; d=yhetil.org; t=1711371049; a=rsa-sha256; cv=none; b=TLnKa75nh+p29wITXgkCQ79L2HIYMgMzMs6TNHP9toZcMPYBLuED65BPHerlyHzx+/ViUV jY27D4v5Z4wKL8Z8esrgsAIX2eEc+DEZ6kdS9n1y08TGV5XExtkZp9N7iFrWTcTq5ByVUG oAORf47YmQzXP0sWcv9BhGT1z3Uo/dz2zEO1ZypN7SmmRSwarWxT6fktssg3cGcRdaGC0m s6Qga+RzqjL550yktpaMu7EWxwVaYIoZu1DC/3/BuE0k7JIr1N/RC4uDncQISY8Kgdwf1D i2YLzFRg85fMwzvSd9r4StkV9HXoSS8bR9pz1KmgeKC1WomJn7QA3+OqHhA3DQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1711371049; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=srZzV5ozpZpNOc+EOuMhe4Mf9F24rIZROfCwUJLRI/k=; b=rRf/s4YyGPry0QhTGKS5yq6WYiB7QIZI850r3VQxw0ABJ/5ML6yHXh9E0QGzAsB7IkT5jG ZDaqnWUGnc7wSQRImx08eERlHrBtFJ4oDkk0gCC07pQD9eqp5DY2v1GHZq69q00CzqeEeL vSXU8A6QxyR0anDSQoOw4rWnp/F6iG8fLtZ9xEQahw7WGi4JZ2+lhJtM7C9ChIqcp/kmWw xEIJCVvMKT0lqZ5jaxqbcKv9VrA3ocTcdaZJl7LaZRxPRRSJEKmxtOBMjPoduNoLlh9bIq Q+aya7MYHudVEXy+bfW8ApCbDuiQCSSUw2Zcf88/D8mbOmxCraArjr+u1dbCoA== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 38508602EC for ; Mon, 25 Mar 2024 13:50:49 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rojlq-000786-N8; Mon, 25 Mar 2024 08:49:46 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rojlp-000771-0W for emacs-orgmode@gnu.org; Mon, 25 Mar 2024 08:49:45 -0400 Received: from ciao.gmane.io ([116.202.254.214]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rojln-000837-Mn for emacs-orgmode@gnu.org; Mon, 25 Mar 2024 08:49:44 -0400 Received: from list by ciao.gmane.io with local (Exim 4.92) (envelope-from ) id 1rojll-0004Q8-Cn for emacs-orgmode@gnu.org; Mon, 25 Mar 2024 13:49:41 +0100 X-Injected-Via-Gmane: http://gmane.org/ To: emacs-orgmode@gnu.org From: Max Nikulin Subject: Re: [BUG] LaTeX preview should use a subdirectory in /tmp Date: Mon, 25 Mar 2024 19:49:35 +0700 Message-ID: References: <87r0fyo7yo.fsf@localhost> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit User-Agent: Mozilla Thunderbird Content-Language: en-US, ru-RU In-Reply-To: <87r0fyo7yo.fsf@localhost> Received-SPF: pass client-ip=116.202.254.214; envelope-from=geo-emacs-orgmode@m.gmane-mx.org; helo=ciao.gmane.io X-Spam_score_int: 26 X-Spam_score: 2.6 X-Spam_bar: ++ X-Spam_report: (2.6 / 5.0 requ) BAYES_00=-1.9, DKIM_ADSP_CUSTOM_MED=0.001, FORGED_GMAIL_RCVD=1, FORGED_MUA_MOZILLA=2.309, FREEMAIL_FORGED_FROMDOMAIN=0.001, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.249, NML_ADSP_CUSTOM_MED=0.9, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: emacs-orgmode-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Spam-Score: 0.63 X-Migadu-Queue-Id: 38508602EC X-Migadu-Scanner: mx12.migadu.com X-Migadu-Spam-Score: 0.63 X-TUID: WhqJzPqzuN19 On 25/03/2024 18:40, Ihor Radchenko wrote: > Max Nikulin writes: >> This feature should not write temporary files to /tmp directly > > See the attached tentative patch. Thanks for prompt reaction. > +++ b/lisp/org.el > @@ -16361,7 +16361,7 @@ (defun org-create-formula-image > org-format-latex-header > 'snippet))) > (latex-compiler (plist-get processing-info :latex-compiler)) > - (tmpdir temporary-file-directory) > + (tmpdir (concat temporary-file-directory "orgtex/")) > (texfilebase (make-temp-name > (expand-file-name "orgtex" tmpdir))) Since directory name already contains "org", it may be shortened to just "tex" > (texfile (concat texfilebase ".tex")) I would use `make-temp-file' to create TEXFILE and would derive TEXFILEBASE from it. In general it is safer. To create directory I expect a call of a function similar to the following one. Perhaps it exists already somewhere. (defun org-ensure-tmp-dir (dir-symbol prefix) (let ((dir (symbol-value dir-symbol))) ;; Temporary directory has not been cleaned. (or (and dir (file-directory-p dir) dir) (setf (symbol-value dir-symbol) (make-temp-file (or prefix "orgtmp-") 'dir))))) (defvar org-tex-tmpdir nil) Usage example: (org-ensure-tmp-dir 'org-tex-tmpdir "orgtex-") Fixed directory name is not friendly for multi-user systems and predictable name in /tmp might be a source of security issues.