emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed

From: Max Nikulin <manikulin@gmail.com>
To: emacs-orgmode@gnu.org
Subject: Preventing inadvertent global modifications
Date: Tue, 12 Sep 2023 23:47:30 +0700	[thread overview]
Message-ID: <udq4n4$1me$1@ciao.gmane.io> (raw)

Hi,

Yesterday, when I was going to commit changes after editing several 
headings in different places of an Org file, I was surprised by huge 
diff with hundreds of chunks. Tags spread across the whole file were 
adjusted by one or tow spaces. Probably I just accidentally hit C-u 
before setting a tag to a new heading by C-c C-q. Of course, I did not 
noticed it immediately. I managed to create a commit with real changes 
without noise due to tags realignment. However I would like to prevent 
similar issues in future.

I can add a prompt for a particular argument of a function by

(defun nm-safe-org-set-tags-command (&optional arg)
   "Call `org-set-tags-command' requiring to confirm
realigning of all tags."
   (interactive "P")
   (cond
    ((and (equal '(4) arg) (not (yes-or-no-p "Realign all tags? "))))
    (t (call-interactively #'org-set-tags-command))))

(add-hook 'org-mode-hook
	  (lambda ()
	    (define-key org-mode-map (kbd "C-c C-q") 
#'nm-safe-org-set-tags-command)))

The function can be made a bit smarter by adding minimal file size 
threshold.

However almost certainly there are more function "destructive" in a 
similar way. Is there a more general approach to make commands safer in 
respect to global modifications?

next             reply	other threads:[~2023-09-12 18:58 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-12 16:47 Max Nikulin [this message]
2023-09-13  8:02 ` Preventing inadvertent global modifications Ihor Radchenko
2023-09-13 10:50   ` Max Nikulin
2023-09-14 12:56     ` Ihor Radchenko
2023-09-15 11:00       ` Max Nikulin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='udq4n4$1me$1@ciao.gmane.io' \
    --to=manikulin@gmail.com \
    --cc=emacs-orgmode@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).