emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Max Nikulin <manikulin@gmail.com>
To: emacs-orgmode@gnu.org
Subject: Re: [patch] improved: add TTL as defcustom to ox-icalendar
Date: Mon, 3 Jan 2022 18:23:43 +0700	[thread overview]
Message-ID: <squmc0$6hi$1@ciao.gmane.io> (raw)
In-Reply-To: <20220103084141.72d2f384@hsu-hh.de>

On 03/01/2022 14:41, Detlef Steuer wrote:
> 
> The patch in principle is unrelated to nextcloud. That's just my
> use case. The addiditional TTL setting gives a hint to clients
> when to reload an imported ics file that was exported from org.

I think, it is better to wait for comments from an ox-icalendar user. I 
am afraid, you will be tired trying to convince me that TTL should be 
overridden for all users (not to say that I am not a maintainer). I 
assume that some of them might have reasonable default in their server 
configuration.

> Is there any document how to setup an org-mode developer environment?
> Normally I use git, but I even struggled to use org from elpa instead
> of the built-in version, so I avoided touching this house of cards :-)

- info "(org) Installation" https://orgmode.org/manual/Installation.html
- info "(org) Feedback" https://orgmode.org/manual/Feedback.html

After "make autoloads" I usually run
     emacs -Q -L ~/src/org-mode/lisp test.org

In addition, I have a LXC container to run tests (and check for compile 
warnings) in an isolated environment.

> Probably I should use a git clone instead of elpa, if I want to work
> on org?

Maintainers prefer patches generated using "git format-patch".

>> https://orgmode.org/worg/org-contribute.html for some hints addressed
>> to contributors.

I am not completely sure, but you patch may exceed "TINYCHANGE" limit, 
so signing FSF copyright papers may be a prerequisite to accept your patch.




  reply	other threads:[~2022-01-03 11:24 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-30 21:59 [patch] " Detlef Steuer
2022-01-02 13:28 ` [patch] improved: " Detlef Steuer
2022-01-03  6:08   ` Max Nikulin
2022-01-03  7:41     ` Detlef Steuer
2022-01-03 11:23       ` Max Nikulin [this message]
2022-01-03 11:32         ` Detlef Steuer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='squmc0$6hi$1@ciao.gmane.io' \
    --to=manikulin@gmail.com \
    --cc=emacs-orgmode@gnu.org \
    --subject='Re: [patch] improved: add TTL as defcustom to ox-icalendar' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Code repositories for project(s) associated with this inbox:

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).