emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Max Nikulin <manikulin@gmail.com>
To: emacs-orgmode@gnu.org
Subject: Re: [patch] improved: add TTL as defcustom to ox-icalendar
Date: Mon, 3 Jan 2022 13:08:54 +0700	[thread overview]
Message-ID: <squ3tp$hvd$1@ciao.gmane.io> (raw)
In-Reply-To: <20220102142849.0af72bcb@hsu-hh.de>

On 02/01/2022 20:28, Detlef Steuer wrote:
> 
>> This is my first try ever to contribute anything in elisp.

Thanks for the patch. It is tracked on https://updates.orgmode.org/

It is easier to review and to apply a patch when it it is prepared in 
context format ("-u" option of diff). Several additional lines of code 
above and below changed ones makes the patch more tolerate to unrelated 
changes in the same file. It is a hint for humans as well.

See info "(diffutils) Tips for Patch Producers" 
https://www.gnu.org/software/diffutils/manual/html_node/Tips-for-Patch-Producers.html 
or "NOTES FOR PATCH SENDERS" section in "man patch".

If you have never used git (or other VCS) before then it is likely an 
overkill for a single patch, diff output with manually added description 
is OK. However you may find such tool rather convenient as number of 
changes will grow. See https://orgmode.org/worg/org-contribute.html for 
some hints addressed to contributors.

I am not a nextcloud or org-icalendar user, so while I expect that 
suggested change is an improvement, I can say nothing concerning the code.



  reply	other threads:[~2022-01-03  6:10 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-30 21:59 [patch] " Detlef Steuer
2022-01-02 13:28 ` [patch] improved: " Detlef Steuer
2022-01-03  6:08   ` Max Nikulin [this message]
2022-01-03  7:41     ` Detlef Steuer
2022-01-03 11:23       ` Max Nikulin
2022-01-03 11:32         ` Detlef Steuer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='squ3tp$hvd$1@ciao.gmane.io' \
    --to=manikulin@gmail.com \
    --cc=emacs-orgmode@gnu.org \
    --subject='Re: [patch] improved: add TTL as defcustom to ox-icalendar' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Code repositories for project(s) associated with this inbox:

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).