From: Maxim Nikulin <manikulin@gmail.com>
To: emacs-orgmode@gnu.org
Subject: [Patch] tests for org-remove-invisible
Date: Fri, 21 May 2021 00:06:01 +0700 [thread overview]
Message-ID: <s864tq$jet$1@ciao.gmane.io> (raw)
In-Reply-To: <s5p88r$go9$1@ciao.gmane.io>
The main patch that fixes org-remove-invisible to improve list sorting is landed.
Let me remind that there were patches that added more test cases:
https://orgmode.org/list/s5p88r$go9$1@ciao.gmane.io
Is there any interest in them?
In the following subthread Nicolas mentioned that some of them could fail
https://orgmode.org/list/87r1j6b6ku.fsf@nicolasgoaziou.fr
I do not see any reason for failure. I just have tried C.UTF-8, en_US.UTF-8,
es_ES.UTF-8, and ru_RU.UTF-8 locales (interactively) and do not see any
problem. This set of locales has 3 different collation rules,
however I do not think it matters for tests.
On 20/04/2021 19:37, Maxim Nikulin wrote:
> On 20/04/2021 00:50, Nicolas Goaziou wrote:
>> Maxim Nikulin writes:
>>
>>> On 19/04/2021 23:08, Nicolas Goaziou wrote:
>>>>> + ;; Space role in sorting.
>>>>> + ;; Test would fail for locales with ignored space, e.g. en_US, it works
>>>>> + ;; in C and currently rare locales having significant space (es_ES, pl_PL)
>>>>> + (should
>>>>> + (equal "- Time stamp\n- Timer\n"
>>>>> + (org-test-with-temp-text "- Timer\n- Time stamp\n"
>>>>> + (org-sort-list t ?a)
>>>>> + (buffer-string))))))
>>>> Since this test is bound to fail for some developers, I assume it
>>>> shouldn't be included.
>>>
>>> Locale "C" is forced for this group of tests.
>>
>> Sorry, I don't understand. There is no locale change around this test,
>> so it will fail, for example, for me. I wouldn't want to get a noisy
>> failure each time I run tests.
>
> Certainly flaky tests must be avoided. However I can not identify the source of confusion (yours or mine).
>
> There is redefinition of `string-collate-lessp' to run tests with "C" locale:
> https://code.orgmode.org/bzg/org-mode/src/master/testing/lisp/test-org-list.el#L1207
>
> And it works for me
next prev parent reply other threads:[~2021-05-20 17:22 UTC|newest]
Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-02 18:15 [Patch] to correctly sort the items with emphasis marks in a list Juan Manuel Macías
2021-04-09 22:28 ` Nicolas Goaziou
2021-04-10 0:01 ` Juan Manuel Macías
2021-04-10 10:19 ` Nicolas Goaziou
2021-04-10 11:41 ` Juan Manuel Macías
2021-04-13 17:31 ` Maxim Nikulin
2021-04-13 19:08 ` Juan Manuel Macías
2021-04-14 15:42 ` Maxim Nikulin
2021-04-14 15:51 ` Maxim Nikulin
2021-04-14 17:07 ` Juan Manuel Macías
2021-04-14 21:36 ` Juan Manuel Macías
2021-04-15 14:58 ` Maxim Nikulin
2021-04-15 18:21 ` Juan Manuel Macías
2021-04-16 14:59 ` Maxim Nikulin
2021-04-16 15:30 ` Maxim Nikulin
2021-04-17 13:27 ` Maxim Nikulin
2021-04-18 17:52 ` Juan Manuel Macías
2021-04-18 21:20 ` Juan Manuel Macías
2021-04-19 8:33 ` Nicolas Goaziou
2021-04-19 12:34 ` Maxim Nikulin
2021-04-19 16:08 ` Nicolas Goaziou
2021-04-19 17:00 ` Greg Minshall
2021-04-19 17:17 ` Tom Gillespie
2021-04-19 18:00 ` Greg Minshall
2021-04-19 17:36 ` Maxim Nikulin
2021-04-19 17:50 ` Nicolas Goaziou
2021-04-20 12:37 ` Maxim Nikulin
2021-04-20 12:20 ` Maxim Nikulin
2021-04-20 13:57 ` Nicolas Goaziou
2021-04-20 15:51 ` Maxim Nikulin
2021-04-20 20:37 ` Nicolas Goaziou
2021-04-21 13:10 ` Maxim Nikulin
2021-04-21 15:45 ` Juan Manuel Macías
2021-04-24 14:41 ` Maxim Nikulin
2021-05-20 17:06 ` Maxim Nikulin [this message]
2021-05-20 18:06 ` [Patch] tests for org-remove-invisible Nicolas Goaziou
2021-09-27 16:53 ` Max Nikulin
2021-11-25 12:11 ` [Patch] to correctly sort the items with emphasis marks in a list Ihor Radchenko
2021-11-25 16:59 ` Max Nikulin
2021-05-15 20:43 ` Bastien
2021-05-15 22:09 ` Nicolas Goaziou
2021-05-16 6:04 ` Bastien
2021-04-28 5:46 ` Bastien
2021-04-28 6:37 ` Nicolas Goaziou
2021-04-28 6:49 ` Bastien
2021-04-28 8:04 ` Bastien
2021-05-15 13:32 ` Bastien
2021-05-15 15:10 ` Maxim Nikulin
2021-05-15 20:44 ` Bastien
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='s864tq$jet$1@ciao.gmane.io' \
--to=manikulin@gmail.com \
--cc=emacs-orgmode@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).