From: "Juan Manuel Macías" <maciaschain@posteo.net>
To: Nicolas Goaziou <mail@nicolasgoaziou.fr>
Cc: orgmode <emacs-orgmode@gnu.org>
Subject: Re: [Patch] to correctly sort the items with emphasis marks in a list
Date: Sat, 10 Apr 2021 02:01:12 +0200 [thread overview]
Message-ID: <87blanxb1z.fsf@posteo.net> (raw)
In-Reply-To: <874kgft7n1.fsf@nicolasgoaziou.fr> (Nicolas Goaziou's message of "Sat, 10 Apr 2021 00:28:34 +0200")
[-- Attachment #1: Type: text/plain, Size: 331 bytes --]
Hellow Nicolas:
Nicolas Goaziou writes:
> Thank you.
>
> Could you apply the same fix to the `org-verbatim-re' match above, and
> provide an appropriate commit message?
Done! I've attached the corrected patch. Sorry for the flaws in me
previous patch: I'm a bit of a novice at submitting patches...
Best regards,
Juan Manuel
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-Remove-spurious-spaces-in-org-sort-remove-invisible.patch --]
[-- Type: text/x-patch, Size: 1172 bytes --]
From ab104bb079e3e32d622a6ff53824b5047dc25c14 Mon Sep 17 00:00:00 2001
From: Juan Manuel Macias <maciaschain@posteo.net>
Date: Fri, 2 Apr 2021 21:20:17 +0200
Subject: [PATCH] Remove spurious spaces in org-sort-remove-invisible
Some spurious spaces in org-sort-remove-invisible is causing
org-sort-list not to sort correctly (alphabetically) the items that
contain emphasis marks in a plain list
---
lisp/org.el | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/lisp/org.el b/lisp/org.el
index 675a614e2..74e2afac9 100644
--- a/lisp/org.el
+++ b/lisp/org.el
@@ -8113,9 +8113,9 @@ Optional argument WITH-CASE means sort case-sensitively."
"Remove invisible part of links and emphasis markers from string S."
(remove-text-properties 0 (length s) org-rm-props s)
(replace-regexp-in-string
- org-verbatim-re (lambda (m) (format "%s " (match-string 4 m)))
+ org-verbatim-re (lambda (m) (format "%s" (match-string 4 m)))
(replace-regexp-in-string
- org-emph-re (lambda (m) (format " %s " (match-string 4 m)))
+ org-emph-re (lambda (m) (format "%s" (match-string 4 m)))
(org-link-display-format s)
t t) t t))
--
2.26.0
next prev parent reply other threads:[~2021-04-10 0:02 UTC|newest]
Thread overview: 54+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-02 18:15 [Patch] to correctly sort the items with emphasis marks in a list Juan Manuel Macías
2021-04-09 22:28 ` Nicolas Goaziou
2021-04-10 0:01 ` Juan Manuel Macías [this message]
2021-04-10 10:19 ` Nicolas Goaziou
2021-04-10 11:41 ` Juan Manuel Macías
2021-04-13 17:31 ` Maxim Nikulin
2021-04-13 19:08 ` Juan Manuel Macías
2021-04-14 15:42 ` Maxim Nikulin
2021-04-14 15:51 ` Maxim Nikulin
2021-04-14 17:07 ` Juan Manuel Macías
2021-04-14 21:36 ` Juan Manuel Macías
2021-04-15 14:58 ` Maxim Nikulin
2021-04-15 18:21 ` Juan Manuel Macías
2021-04-16 14:59 ` Maxim Nikulin
2021-04-16 15:30 ` Maxim Nikulin
2021-04-17 13:27 ` Maxim Nikulin
2021-04-18 17:52 ` Juan Manuel Macías
2021-04-18 21:20 ` Juan Manuel Macías
2021-04-19 8:33 ` Nicolas Goaziou
2021-04-19 12:34 ` Maxim Nikulin
2021-04-19 16:08 ` Nicolas Goaziou
2021-04-19 17:00 ` Greg Minshall
2021-04-19 17:17 ` Tom Gillespie
2021-04-19 18:00 ` Greg Minshall
2021-04-19 17:36 ` Maxim Nikulin
2021-04-19 17:50 ` Nicolas Goaziou
2021-04-20 12:37 ` Maxim Nikulin
2021-04-20 12:20 ` Maxim Nikulin
2021-04-20 13:57 ` Nicolas Goaziou
2021-04-20 15:51 ` Maxim Nikulin
2021-04-20 20:37 ` Nicolas Goaziou
2021-04-21 13:10 ` Maxim Nikulin
2021-04-21 15:45 ` Juan Manuel Macías
2021-04-24 14:41 ` Maxim Nikulin
2021-05-20 17:06 ` [Patch] tests for org-remove-invisible Maxim Nikulin
2021-05-20 18:06 ` Nicolas Goaziou
2021-09-27 16:53 ` Max Nikulin
2021-11-25 12:11 ` [Patch] to correctly sort the items with emphasis marks in a list Ihor Radchenko
2021-11-25 16:59 ` Max Nikulin
2021-05-15 20:43 ` Bastien
2021-05-15 22:09 ` Nicolas Goaziou
2021-05-16 6:04 ` Bastien
2021-04-28 5:46 ` Bastien
2021-04-28 6:37 ` Nicolas Goaziou
2021-04-28 6:49 ` Bastien
2021-04-28 8:04 ` Bastien
2021-05-15 13:32 ` Bastien
2021-05-15 15:10 ` Maxim Nikulin
2021-05-15 20:44 ` Bastien
2021-04-12 13:50 Juan Manuel Macías
[not found] <mailman.57.1618243212.17744.emacs-orgmode@gnu.org>
2021-04-12 18:51 ` Ypo
2021-04-12 23:18 ` Juan Manuel Macías
2021-04-12 23:52 ` Samuel Wales
2021-04-13 14:16 ` Juan Manuel Macías
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87blanxb1z.fsf@posteo.net \
--to=maciaschain@posteo.net \
--cc=emacs-orgmode@gnu.org \
--cc=mail@nicolasgoaziou.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).