* [PATCH] org-contribute: fix a type by changing "column" to "colon"
@ 2014-11-15 19:03 Richard Y. Kim
2014-11-15 23:28 ` Nicolas Goaziou
0 siblings, 1 reply; 2+ messages in thread
From: Richard Y. Kim @ 2014-11-15 19:03 UTC (permalink / raw)
To: emacs-orgmode
[-- Attachment #1: Type: text/plain, Size: 503 bytes --]
Attached patch fixes a typo and also removes trailing white spaces.
The white spaces were removed due to adding a hook to remove them as
shown here:
(defun kimr-before-save-hook ()
"Delete trailing white spaces only in a few modes."
(when (eq major-mode 'org-mode)
(delete-trailing-whitespace)))
(add-hook 'before-save-hook 'kimr-before-save-hook)
Please let me know if trailing white spaces should not be removed in
general so that I will omit such changes in future patches.
Thanks.
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-org-contribute-fix-a-type-by-changing-column-to-colo.patch --]
[-- Type: text/x-diff, Size: 3434 bytes --]
From 06bb6361813dad0f1ac111c573f5dd325c47d9e7 Mon Sep 17 00:00:00 2001
From: Kim <emacs18@gmail.com>
Date: Sat, 15 Nov 2014 10:58:25 -0800
Subject: [PATCH] org-contribute: fix a type by changing "column" to "colon"
* worg/org-contribute.org: fixed a typo. Also removed trailing white
spaces in 8 lines.
TINYCHANGE
---
org-contribute.org | 18 +++++++++---------
1 file changed, 9 insertions(+), 9 deletions(-)
diff --git a/org-contribute.org b/org-contribute.org
index cbcee3f..c763b25 100644
--- a/org-contribute.org
+++ b/org-contribute.org
@@ -4,7 +4,7 @@
#+OPTIONS: H:3 num:nil toc:t \n:nil ::t |:t ^:t -:t f:t *:t tex:t d:(HIDE) tags:not-in-toc
#+STARTUP: align fold nodlcheck hidestars oddeven lognotestate
#+SEQ_TODO: TODO(t) INPROGRESS(i) WAITING(w@) | DONE(d) CANCELED(c@)
-#+TAGS: Write(w) Update(u) Fix(f) Check(c)
+#+TAGS: Write(w) Update(u) Fix(f) Check(c)
#+LANGUAGE: en
#+PRIORITIES: A C B
#+CATEGORY: worg
@@ -34,7 +34,7 @@ where your contribution will be useful:
- you can submit *patches* -- You can submit patches to the mailing
list. See the [[For Org contributors: preferred way of submitting patches][Preferred way of submitting patches]] section for
- details. You can run =make test= to check that your patch does
+ details. You can run =make test= to check that your patch does
not introduce new bugs.
If your patch is against a file that is part of Emacs, then your
@@ -42,7 +42,7 @@ where your contribution will be useful:
15 lines/ (See the [[http://bzr.savannah.gnu.org/lh/emacs/trunk/annotate/head:/etc/CONTRIBUTE][etc/CONTRIBUTE file in GNU Emacs]].) If you
contribute more, you have to assign the copyright of your
contribution to the Free Software Foundation (see below).
-
+
- you can submit Org *add-ons* -- there are many Org add-ons.
- The best way is to submit your code to [[file:org-mailing-list.org][the mailing list]] to discuss
it with people.
@@ -271,7 +271,7 @@ A commit message should be constructed in the following way:
- Line 1 of the commit message should always be a short description of
the overall change. Line 1 does /not/ get a dot at the end and does
not start with a star. Generally, it starts with the filename that
- has been changed, followed by a column.
+ has been changed, followed by a colon.
- Line 2 is an empty line.
@@ -283,7 +283,7 @@ A commit message should be constructed in the following way:
: (org-timer-set-timer): Use the number of minutes in the Effort
: property as the default timer value. Three prefix arguments will
: ignore the Effort value property.
-
+
- After the changelog, another empty line should come before any
additional information that the committer wishes to provide in order
to explain the patch.
@@ -307,18 +307,18 @@ Here is an example for such a message:
#+begin_example
org-capture.el: Fix the case of using a template file
-
+
,* lisp/org-capture.el (org-capture-set-plist): Make sure txt is a
string before calling `string-match'.
(org-capture-templates): Fix customization type.
,* doc/org.texi (Capture): Document using a file for a template.
-
+
The problem here was that a wrong keyword was given in the
customization type. This let to a string-match against a list value.
-
+
Modified from a patch proposal by Johan Friis.
-
+
TINYCHANGE
#+end_example
--
1.9.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] org-contribute: fix a type by changing "column" to "colon"
2014-11-15 19:03 [PATCH] org-contribute: fix a type by changing "column" to "colon" Richard Y. Kim
@ 2014-11-15 23:28 ` Nicolas Goaziou
0 siblings, 0 replies; 2+ messages in thread
From: Nicolas Goaziou @ 2014-11-15 23:28 UTC (permalink / raw)
To: Richard Y. Kim; +Cc: emacs-orgmode
Hello,
emacs18@gmail.com (Richard Y. Kim) writes:
> Attached patch fixes a typo and also removes trailing white spaces.
Applied. Thank you.
>
[...]
> Please let me know if trailing white spaces should not be removed in
> general so that I will omit such changes in future patches.
> Thanks.
In general, you only remove trailing white spaces from lines or function
you actually modify. However, we're talking about Worg here, where there
is no formal rule about patches and commit messages.
You can send your SSH public key to Bastien if you want to further
improve Worg. See <http://orgmode.org/worg/worg-git.html>.
> TINYCHANGE
You don't need that for Worg.
Regards,
--
Nicolas Goaziou
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-11-15 23:27 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-11-15 19:03 [PATCH] org-contribute: fix a type by changing "column" to "colon" Richard Y. Kim
2014-11-15 23:28 ` Nicolas Goaziou
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).