Re: [PATCH] org.el: Warning for unsupported markers in `org-set-emphasis-alist'

[Max Nikulin <manikulin@gmail.com>]

On 04/11/2022 13:53, Ihor Radchenko wrote:
> 
> I have reviewed the patch, and I'd like to suggest a new version with the
> following changes:

Great! I have not tried your patch in action, but I do not see 
substantial changes.

> 1. Use `set-default-toplevel-value' instead of `set' that might be
>     quirky in some scenarios.

Almost certainly it is an improvement. Docs in the Emacs repo have been 
updated, but the published variant still suggests `set-default' 
https://www.gnu.org/software/emacs/manual/html_node/elisp/Variable-Definitions.html

> 2. Use `warn' instead of `message' as more alarming.

I do not mind.

> 3. Remove verbatim in ("=" org-verbatim verbatim), ("~" org-code
>     verbatim), and the :type spec.  AFAIU, they are unused. But can you
>     please double-check?

It seems, before the following commit, verbatim was used to suppress 
flyspell, but now "~" and "=" are hardcoded.

9fb2e047d 2016-12-08 09:44:26 +0100 Nicolas Goaziou: Split `org-emph-re' 
and `org-verbatim-re'

I think, verbatim option should not be removed from `defcustom' :type 
just now. For some users it might cause fallback to raw lisp value in 
easy customization UI. Perhaps another warning should be added to the 
`org-set-emphasis-alist' validator and the option should be labeled as 
unused in the :type definition.