Fix time regexp in org-get-entries-from-diary

Fix time regexp in org-get-entries-from-diary

[Thomas Fitzsimmons]

[-- Attachment #1: Type: text/plain, Size: 242 bytes --]

Dear Org developers,

I filed a bug report in Emacs debbugs, but probably should have sent it
here instead:

   http://debbugs.gnu.org/cgi/bugreport.cgi?bug=38599

The attached patch appears to fix the bug.  Does it look OK?

Thanks,
Thomas


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-Fix-time-regexp-in-org-get-entries-from-diary.patch --]
[-- Type: text/x-diff, Size: 951 bytes --]

From 6102f07d61ee5d128701b7d3799b2e278aa79248 Mon Sep 17 00:00:00 2001
From: Thomas Fitzsimmons <fitzsim@fitzsim.org>
Date: Sun, 15 Dec 2019 12:20:05 -0500
Subject: [PATCH] Fix time regexp in org-get-entries-from-diary

* lisp/org-agenda.el (org-get-entries-from-diary): Make time regular
expression more precise.

Reported-by: Justin Abrahms <justin@abrah.ms>
---
 lisp/org-agenda.el | 1 +
 1 file changed, 1 insertion(+)

diff --git a/lisp/org-agenda.el b/lisp/org-agenda.el
index 6391e0e9c..f07c86b9a 100644
--- a/lisp/org-agenda.el
+++ b/lisp/org-agenda.el
@@ -5135,6 +5135,7 @@ (defun org-get-entries-from-diary (date)
 	  (cons 'org-diary-default-entry diary-list-entries-hook))
 	 (diary-file-name-prefix nil) ; turn this feature off
 	 (diary-modify-entry-list-string-function 'org-modify-diary-entry-string)
+	 (diary-time-regexp (concat "^" diary-time-regexp))
 	 entries
 	 (org-disable-agenda-to-diary t))
     (save-excursion
-- 
2.24.1

Re: Fix time regexp in org-get-entries-from-diary

[Nicolas Goaziou]

Hello,

Thomas Fitzsimmons <fitzsim@fitzsim.org> writes:

> I filed a bug report in Emacs debbugs, but probably should have sent it
> here instead:
>
>    http://debbugs.gnu.org/cgi/bugreport.cgi?bug=38599
>
> The attached patch appears to fix the bug.  Does it look OK?

Applied. Thank you.

I added your name to the list of contributors who haven't signed FSF
papers. Please let me know if you did so I can update your status.

Regards,

-- 
Nicolas Goaziou

Re: Fix time regexp in org-get-entries-from-diary

[Thomas Fitzsimmons]

Hi Nicolas,

Nicolas Goaziou <mail@nicolasgoaziou.fr> writes:

> Hello,
>
> Thomas Fitzsimmons <fitzsim@fitzsim.org> writes:
>
>> I filed a bug report in Emacs debbugs, but probably should have sent it
>> here instead:
>>
>>    http://debbugs.gnu.org/cgi/bugreport.cgi?bug=38599
>>
>> The attached patch appears to fix the bug.  Does it look OK?
>
> Applied. Thank you.

Thanks.

> I added your name to the list of contributors who haven't signed FSF
> papers. Please let me know if you did so I can update your status.

I have signed FSF papers for contributions to GNU Emacs.

Thomas

Re: Fix time regexp in org-get-entries-from-diary

[Nicolas Goaziou]

Hello,

Thomas Fitzsimmons <fitzsim@fitzsim.org> writes:

> I have signed FSF papers for contributions to GNU Emacs.

I updated your status, then. Thank you for letting me know.

Regards,

--
Nicolas Goaziou