emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed

From: Thomas Fitzsimmons <fitzsim@fitzsim.org>
To: emacs-orgmode@gnu.org
Subject: Fix time regexp in org-get-entries-from-diary
Date: Thu, 19 Dec 2019 21:53:07 -0500	[thread overview]
Message-ID: <m3mubnu2r0.fsf@fitzsim.org> (raw)

[-- Attachment #1: Type: text/plain, Size: 242 bytes --]

Dear Org developers,

I filed a bug report in Emacs debbugs, but probably should have sent it
here instead:

   http://debbugs.gnu.org/cgi/bugreport.cgi?bug=38599

The attached patch appears to fix the bug.  Does it look OK?

Thanks,
Thomas


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-Fix-time-regexp-in-org-get-entries-from-diary.patch --]
[-- Type: text/x-diff, Size: 951 bytes --]

From 6102f07d61ee5d128701b7d3799b2e278aa79248 Mon Sep 17 00:00:00 2001
From: Thomas Fitzsimmons <fitzsim@fitzsim.org>
Date: Sun, 15 Dec 2019 12:20:05 -0500
Subject: [PATCH] Fix time regexp in org-get-entries-from-diary

* lisp/org-agenda.el (org-get-entries-from-diary): Make time regular
expression more precise.

Reported-by: Justin Abrahms <justin@abrah.ms>
---
 lisp/org-agenda.el | 1 +
 1 file changed, 1 insertion(+)

diff --git a/lisp/org-agenda.el b/lisp/org-agenda.el
index 6391e0e9c..f07c86b9a 100644
--- a/lisp/org-agenda.el
+++ b/lisp/org-agenda.el
@@ -5135,6 +5135,7 @@ (defun org-get-entries-from-diary (date)
 	  (cons 'org-diary-default-entry diary-list-entries-hook))
 	 (diary-file-name-prefix nil) ; turn this feature off
 	 (diary-modify-entry-list-string-function 'org-modify-diary-entry-string)
+	 (diary-time-regexp (concat "^" diary-time-regexp))
 	 entries
 	 (org-disable-agenda-to-diary t))
     (save-excursion
-- 
2.24.1

next             reply	other threads:[~2019-12-20  2:53 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-20  2:53 Thomas Fitzsimmons [this message]
2019-12-22 14:16 ` Fix time regexp in org-get-entries-from-diary Nicolas Goaziou
2019-12-23 16:06   ` Thomas Fitzsimmons
2019-12-23 17:27     ` Nicolas Goaziou

find likely ancestor, descendant, or conflicting patches for this message:
dfblob:6391e0e9 dfblob:f07c86b9
	(help)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m3mubnu2r0.fsf@fitzsim.org \
    --to=fitzsim@fitzsim.org \
    --cc=emacs-orgmode@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).