Bug: Deleting region in table [9.0.8 (9.0.8-dist @ /Users/nick/.emacs.d/lisp/org/)]

Bug: Deleting region in table [9.0.8 (9.0.8-dist @ /Users/nick/.emacs.d/lisp/org/)]

[Nick Helm]

Remember to cover the basics, that is, what you expected to happen and
what in fact did happen.  You don't know how to make a good report?  See

     http://orgmode.org/manual/Feedback.html#Feedback

Your bug report will be posted to the Org mailing list.
------------------------------------------------------------------------

Deleting a region within an org table causes point to jump.

Recipe:

  Emacs -Q
  org-mode

  ;make a table
  | this is a simple | table |

  double-click "simple" ;place region over a word
  <backspace>

With the last command, I expect the word "simple" to be deleted, the
right-hand "|" separator (and following column) to close up six chars,
and point to end up to the right of "a ".

Note however that point winds up in the middle of the next column over
the word "table". Or, more precisely, one screen column to the left of
where it started. An additional space is also inserted in the first
column.

I had a look at org.el and I think this occurs because the function
`org-delete-backward-char' (which my system calls by default to delete
text in a table) is unaware of the region and treats the case above as a
single char backwards delete.

Tweaking the function like this seems to help.

--- a/src/org.el	2017-06-06 03:25:46.000000000 +1200
+++ b/src/org.el	2017-08-13 15:52:32.000000000 +1200
@@ -20243,6 +20243,7 @@
     (org-check-before-invisible-edit 'delete-backward)
     (if (and (org-at-table-p)
 	     (eq N 1)
+	     (not (org-region-active-p))
 	     (string-match "|" (buffer-substring (point-at-bol) (point)))
 	     (looking-at ".*?|"))
 	(let ((pos (point))

The situation is the same with org 9.0.9 and master.



Emacs  : GNU Emacs 25.2.1 (x86_64-apple-darwin16.7.0, Carbon Version 157 AppKit 1504.83)
 of 2017-08-12
Package: Org mode version 9.0.8 (9.0.8-dist @ /Users/nick/.emacs.d/lisp/org/)

current state:
==============
(setq
 org-export-backends '(ascii html latex odt)
 org-tab-first-hook '(org-babel-hide-result-toggle-maybe org-babel-header-arg-expand)
 org-adapt-indentation nil
 org-speed-command-hook '(org-speed-command-default-hook org-babel-speed-command-hook)
 org-occur-hook '(org-first-headline-recenter)
 org-metaup-hook '(org-babel-load-in-session-maybe)
 org-confirm-shell-link-function 'yes-or-no-p
 org-image-actual-width 150
 org-startup-align-all-tables t
 org-startup-folded nil
 org-after-todo-state-change-hook '(org-clock-out-if-current)
 org-src-mode-hook '(org-src-babel-configure-edit-buffer org-src-mode-configure-edit-buffer)
 org-agenda-before-write-hook '(org-agenda-add-entry-text)
 org-babel-pre-tangle-hook '(save-buffer)
 org-mode-hook '(#[0 "\300\301\302\303\304$\207"
                   [add-hook change-major-mode-hook org-show-block-all append local] 5]
                 #[0 "\300\301\302\303\304$\207"
                   [add-hook change-major-mode-hook org-babel-show-result-all append local] 5]
                 org-babel-result-hide-spec org-babel-hide-all-hashes
                 (lambda nil
                  (face-remap-add-relative (quote font-lock-comment-face) (quote org-comment))
                  (font-lock-add-keywords nil
                   (quote (("^\\s-*\\([+-]\\|[0-9]+\\.\\)\\s-" 1 (quote org-list-bullet)))))
                  )
                 )
 org-archive-hook '(org-attach-archive-delete-maybe)
 org-cycle-hook '(org-cycle-hide-archived-subtrees org-cycle-hide-drawers org-cycle-show-empty-lines
                  org-optimize-window-after-visibility-change)
 org-fontify-quote-and-verse-blocks t
 org-export-before-parsing-hook '((lambda (x) (setq org-odt-styles-dir nh-emacs-etc)))
 org-catch-invisible-edits 'show
 org-confirm-elisp-link-function 'yes-or-no-p
 org-metadown-hook '(org-babel-pop-to-session-maybe)
 org-link-parameters '(("id" :follow org-id-open)
                       ("rmail" :follow org-rmail-open :store org-rmail-store-link)
                       ("mhe" :follow org-mhe-open :store org-mhe-store-link)
                       ("irc" :follow org-irc-visit :store org-irc-store-link)
                       ("info" :follow org-info-open :export org-info-export :store org-info-store-link)
                       ("gnus" :follow org-gnus-open :store org-gnus-store-link)
                       ("docview" :follow org-docview-open :export org-docview-export :store
                        org-docview-store-link)
                       ("bibtex" :follow org-bibtex-open :store org-bibtex-store-link)
                       ("bbdb" :follow org-bbdb-open :export org-bbdb-export :complete
                        org-bbdb-complete-link :store org-bbdb-store-link)
                       ("w3m" :store org-w3m-store-link) ("file+sys") ("file+emacs")
                       ("doi" :follow org--open-doi-link) ("elisp" :follow org--open-elisp-link)
                       ("file" :complete org-file-complete-link)
                       ("ftp" :follow (lambda (path) (browse-url (concat "ftp:" path))))
                       ("help" :follow org--open-help-link)
                       ("http" :follow (lambda (path) (browse-url (concat "http:" path))))
                       ("https" :follow (lambda (path) (browse-url (concat "https:" path))))
                       ("mailto" :follow (lambda (path) (browse-url (concat "mailto:" path))))
                       ("message" :follow (lambda (path) (browse-url (concat "message:" path))))
                       ("news" :follow (lambda (path) (browse-url (concat "news:" path))))
                       ("shell" :follow org--open-shell-link))
 org-clock-out-hook '(org-clock-remove-empty-clock-drawer)
 org-descriptive-links nil
 )

Re: Bug: Deleting region in table [9.0.8 (9.0.8-dist @ /Users/nick/.emacs.d/lisp/org/)]

[Nicolas Goaziou]

Hello,

Nick Helm <nick@tenpoint.co.nz> writes:

> Deleting a region within an org table causes point to jump.
>
> Recipe:
>
>   Emacs -Q
>   org-mode
>
>   ;make a table
>   | this is a simple | table |
>
>   double-click "simple" ;place region over a word
>   <backspace>
>
> With the last command, I expect the word "simple" to be deleted, the
> right-hand "|" separator (and following column) to close up six chars,
> and point to end up to the right of "a ".
>
> Note however that point winds up in the middle of the next column over
> the word "table". Or, more precisely, one screen column to the left of
> where it started. An additional space is also inserted in the first
> column.
>
> I had a look at org.el and I think this occurs because the function
> `org-delete-backward-char' (which my system calls by default to delete
> text in a table) is unaware of the region and treats the case above as a
> single char backwards delete.

Good catch!

Fixed. Thank you for the report and the analysis.

Regards,

-- 
Nicolas Goaziou

Re: Bug: Deleting region in table [9.0.8 (9.0.8-dist @ /Users/nick/.emacs.d/lisp/org/)]

[Nick Helm]

Hi Nicholas,

I see the fix for this bug (commit
91c68865c644277772028faca96b7ff03541e7cf) was merged for org 9.0.10.

However, I installed 9.0.10 this morning and the bug still occurs.

Apologies if I am missing something. 

With thanks,
Nick H

On Thu, Aug 17 2017, Nicolas Goaziou wrote:

> Nick Helm <nick@tenpoint.co.nz> writes:
>
>> Deleting a region within an org table causes point to jump.
>>
>> Recipe:
>>
>>   Emacs -Q
>>   org-mode
>>
>>   ;make a table
>>   | this is a simple | table |
>>
>>   double-click "simple" ;place region over a word
>>   <backspace>
>>
>> With the last command, I expect the word "simple" to be deleted, the
>> right-hand "|" separator (and following column) to close up six chars,
>> and point to end up to the right of "a ".
>>
>> Note however that point winds up in the middle of the next column over
>> the word "table". Or, more precisely, one screen column to the left of
>> where it started. An additional space is also inserted in the first
>> column.
>>
>> I had a look at org.el and I think this occurs because the function
>> `org-delete-backward-char' (which my system calls by default to delete
>> text in a table) is unaware of the region and treats the case above as a
>> single char backwards delete.
>
> Good catch!
>
> Fixed. Thank you for the report and the analysis.