From: Dave Abrahams <dave@boostpro.com>
To: emacs-orgmode@gnu.org
Subject: Bug: [patch] Fixes behavior of org-agenda-tree-to-indirect-buffer [7.8.02 (release_7.7.796.gc512)]
Date: Fri, 17 Feb 2012 22:48:13 -1000 [thread overview]
Message-ID: <m2boow1q9e.fsf@boostpro.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 553 bytes --]
Remember to cover the basics, that is, what you expected to happen and
what in fact did happen. You don't know how to make a good report? See
http://orgmode.org/manual/Feedback.html#Feedback
Your bug report will be posted to the Org-mode mailing list.
------------------------------------------------------------------------
This function was misbehaving in a number of ways. The enclosed patch
represents the changes necessary to make it work properly, accumulated
over several weeks of testing. Sorry if the description is a bit vague.
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-Fix-behavior-of-org-agenda-tree-to-indirect-buffer.patch --]
[-- Type: text/x-patch, Size: 1563 bytes --]
From c5128d1666e5fbe29a2fdfd6ee51622f05c42e9b Mon Sep 17 00:00:00 2001
From: Dave Abrahams <dave@boostpro.com>
Date: Fri, 17 Feb 2012 22:44:13 -1000
Subject: [PATCH] Fix behavior of org-agenda-tree-to-indirect-buffer
---
lisp/org-agenda.el | 11 +++++++----
1 files changed, 7 insertions(+), 4 deletions(-)
diff --git a/lisp/org-agenda.el b/lisp/org-agenda.el
index 780794e..0c32b48 100644
--- a/lisp/org-agenda.el
+++ b/lisp/org-agenda.el
@@ -7202,16 +7202,19 @@ use the dedicated frame)."
(if (and current-prefix-arg (listp current-prefix-arg))
(org-agenda-do-tree-to-indirect-buffer)
(let ((agenda-window (selected-window))
- (indirect-window (get-buffer-window org-last-indirect-buffer)))
+ (indirect-window
+ (and org-last-indirect-buffer
+ (get-buffer-window org-last-indirect-buffer))))
(save-window-excursion (org-agenda-do-tree-to-indirect-buffer))
(unwind-protect
- (progn
- (unless indirect-window
+ (progn
+ (unless (and indirect-window (window-live-p indirect-window))
(setq indirect-window (split-window agenda-window)))
(select-window indirect-window)
(switch-to-buffer org-last-indirect-buffer :norecord)
+ (org-set-visibility-according-to-property)
(fit-window-to-buffer indirect-window))
- (select-window agenda-window)))))
+ (select-window agenda-window)))))
(defun org-agenda-do-tree-to-indirect-buffer ()
"Same as `org-agenda-tree-to-indirect-buffer' without saving window."
--
1.7.5.4
[-- Attachment #3: Type: text/plain, Size: 232 bytes --]
Emacs : GNU Emacs 24.0.92.1 (x86_64-apple-darwin, NS apple-appkit-1038.36)
of 2011-12-22 on bob.porkrind.org
Package: Org-mode version 7.8.02 (release_7.7.796.gc512)
--
Dave Abrahams
BoostPro Computing
http://www.boostpro.com
next reply other threads:[~2012-02-18 8:48 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-18 8:48 Dave Abrahams [this message]
2012-02-25 10:26 ` Bug: [patch] Fixes behavior of org-agenda-tree-to-indirect-buffer [7.8.02 (release_7.7.796.gc512)] David Maus
2012-02-25 13:34 ` Dave Abrahams
2012-02-25 15:55 ` David Maus
2012-02-25 19:43 ` Dave Abrahams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m2boow1q9e.fsf@boostpro.com \
--to=dave@boostpro.com \
--cc=emacs-orgmode@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).