From: Steve Purcell <steve@sanityinc.com>
To: emacs-orgmode@gnu.org
Subject: Re: PATCH: Fix malformed "message" links produced by org-mac-link.el
Date: Wed, 24 Sep 2014 16:42:18 +0100 [thread overview]
Message-ID: <m27g0thvol.fsf@sanityinc.com> (raw)
In-Reply-To: m28ul9vxnr.fsf@top.irisa.fr
Alan Schmitt <alan.schmitt@polytechnique.org> writes:
> I just tested it with the current version and I'm not seeing this
> problem. Is there something special about that email that breaks, or are
> you seeing problems with every email?
I see it with every mail. I'm on OS X 10.9.5, but the problem was also
present on 10.9.4.
The "substring" part of the removed code led to the trimming of the
characters at each end, so it's not clear to me how it could ever have
worked, unless the output is routinely wrapped in quotes on others'
machines.
Mysterious indeed.
In any case, there were a few blocks of identical-looking code dotted
around the file: the block appears to have been wisely extracted into
org-mac-paste-applescript-links, but the duplicate code hasn't been
replaced with a call to that function. So this patch does so for the
Mail case, and the same fix should also probably be made in
org-mac-outlook-message-get-links.
-Steve
next prev parent reply other threads:[~2014-09-24 15:42 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-24 10:39 PATCH: Fix malformed "message" links produced by org-mac-link.el Steve Purcell
2014-09-24 15:35 ` Alan Schmitt
2014-09-24 15:42 ` Steve Purcell [this message]
2014-09-24 19:01 ` Alan Schmitt
2014-09-24 19:56 ` Steve Purcell
2014-09-25 6:14 ` Alan Schmitt
2014-10-09 12:15 ` Alan Schmitt
2014-10-09 12:25 ` Steve Purcell
2014-10-09 13:18 ` Alan Schmitt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m27g0thvol.fsf@sanityinc.com \
--to=steve@sanityinc.com \
--cc=emacs-orgmode@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).