From: Alan Schmitt <alan.schmitt@polytechnique.org>
To: Steve Purcell <steve@sanityinc.com>
Cc: emacs-orgmode@gnu.org
Subject: Re: PATCH: Fix malformed "message" links produced by org-mac-link.el
Date: Wed, 24 Sep 2014 21:01:08 +0200 [thread overview]
Message-ID: <m2h9zwzvuz.fsf@polytechnique.org> (raw)
In-Reply-To: <m27g0thvol.fsf@sanityinc.com> (Steve Purcell's message of "Wed, 24 Sep 2014 16:42:18 +0100")
[-- Attachment #1: Type: text/plain, Size: 2167 bytes --]
On 2014-09-24 16:42, Steve Purcell <steve@sanityinc.com> writes:
> Alan Schmitt <alan.schmitt@polytechnique.org> writes:
>> I just tested it with the current version and I'm not seeing this
>> problem. Is there something special about that email that breaks, or are
>> you seeing problems with every email?
>
> I see it with every mail. I'm on OS X 10.9.5, but the problem was also
> present on 10.9.4.
I'm also on 10.9.5. I was probably on 10.9.4 when I tweaked that code.
> The "substring" part of the removed code led to the trimming of the
> characters at each end, so it's not clear to me how it could ever have
> worked, unless the output is routinely wrapped in quotes on others'
> machines.
This was the case here: the string returned by the AppleScript had
quotes (and it still does).
For instance, with the message you mention, the call to
org-as-get-selected-mail returns this (doing a debug):
Result: "\"message://2.b2af716655bbac583727@NY-WEB01::split::Private beta invitation for Emacs Q&A site - Area 51 - Stack Exchange\""
> Mysterious indeed.
>
> In any case, there were a few blocks of identical-looking code dotted
> around the file: the block appears to have been wisely extracted into
> org-mac-paste-applescript-links, but the duplicate code hasn't been
> replaced with a call to that function. So this patch does so for the
> Mail case, and the same fix should also probably be made in
> org-mac-outlook-message-get-links.
It works well for grabbing a single message, but it breaks when grabbing
several. Here is one such broken result:
[[message://9670A832-D0B3-46A8-96BF-05C30D85085D@gmail.com][Re: De passage ˆ San Jose"]]
[["message://4B980C40-DB9A-47A7-95A7-17BB8CF8167F@gmail.com][Re: De passage ˆ San Jose]]
The string returned by the AppleScript was this:
Result: "\"message://4B980C40-DB9A-47A7-95A7-17BB8CF8167F@gmail.com::split::Re: De passage \210 San Jose\nmessage://9670A832-D0B3-46A8-96BF-05C30D85085D@gmail.com::split::Re: De passage \210 San Jose\""
Does it work on your machine with several messages selected?
Best,
Alan
--
OpenPGP Key ID : 040D0A3B4ED2E5C7
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 494 bytes --]
next prev parent reply other threads:[~2014-09-24 19:02 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-24 10:39 PATCH: Fix malformed "message" links produced by org-mac-link.el Steve Purcell
2014-09-24 15:35 ` Alan Schmitt
2014-09-24 15:42 ` Steve Purcell
2014-09-24 19:01 ` Alan Schmitt [this message]
2014-09-24 19:56 ` Steve Purcell
2014-09-25 6:14 ` Alan Schmitt
2014-10-09 12:15 ` Alan Schmitt
2014-10-09 12:25 ` Steve Purcell
2014-10-09 13:18 ` Alan Schmitt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m2h9zwzvuz.fsf@polytechnique.org \
--to=alan.schmitt@polytechnique.org \
--cc=emacs-orgmode@gnu.org \
--cc=steve@sanityinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).