* [BUG] org splitting window weird layout
@ 2010-12-09 10:43 Leo
2011-02-12 14:41 ` Bastien
0 siblings, 1 reply; 4+ messages in thread
From: Leo @ 2010-12-09 10:43 UTC (permalink / raw)
To: emacs-orgmode
Hello all,
Function org-fast-tag-selection may create a three-window layout like
this: http://imagebin.org/127056.
This is due to org-switch-to-buffer-other-window subject to
split-window-sensibly and thus
(org-switch-to-buffer-other-window " *Org tags*")
is not guaranteed to switch to the window created by
(split-window-vertically).
I have temporarily fixed the problem with the patch attached
(http://imagebin.org/127057). I think a proper fix may have to be in
org-switch-to-buffer-other-window, i.e. add an extra argument to
indicate preferring horizontal or vertical split and let bound
split-width-threshold or split-height-threshold accordingly, and fix the
places where it is used.
diff -c /usr/local/unix/site-lisp/orgmode/org.el\~ /usr/local/unix/site-lisp/orgmode/org.el
--- /usr/local/unix/site-lisp/orgmode/org.el~ Mon Dec 6 18:24:00 2010
+++ /usr/local/unix/site-lisp/orgmode/org.el Thu Dec 9 10:30:09 2010
@@ -13026,7 +13026,7 @@
(setq exit-after-next (not exit-after-next)))
(setq expert nil)
(delete-other-windows)
- (split-window-vertically)
+ (set-window-buffer (split-window-vertically) " *Org tags*")
(org-switch-to-buffer-other-window " *Org tags*")
(org-fit-window-to-buffer)))
((or (= c ?\C-g)
Diff finished. Thu Dec 9 10:30:48 2010
HTH,
Leo
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [BUG] org splitting window weird layout
2010-12-09 10:43 [BUG] org splitting window weird layout Leo
@ 2011-02-12 14:41 ` Bastien
2011-02-12 16:59 ` Leo
0 siblings, 1 reply; 4+ messages in thread
From: Bastien @ 2011-02-12 14:41 UTC (permalink / raw)
To: Leo; +Cc: emacs-orgmode
Hi Leo,
Leo <sdl.web@gmail.com> writes:
> Function org-fast-tag-selection may create a three-window layout like
> this: http://imagebin.org/127056.
Perhaps due to my delay in replying, the image disappeared.
Do you still have this problem? If so, can you be so kind as to report
the picture?
Thanks!
--
Bastien
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [BUG] org splitting window weird layout
2011-02-12 14:41 ` Bastien
@ 2011-02-12 16:59 ` Leo
2011-02-12 17:11 ` Bastien
0 siblings, 1 reply; 4+ messages in thread
From: Leo @ 2011-02-12 16:59 UTC (permalink / raw)
To: Bastien; +Cc: emacs-orgmode
On 2011-02-12 22:41 +0800, Bastien wrote:
> Leo <sdl.web@gmail.com> writes:
>
>> Function org-fast-tag-selection may create a three-window layout like
>> this: http://imagebin.org/127056.
>
> Perhaps due to my delay in replying, the image disappeared.
>
> Do you still have this problem? If so, can you be so kind as to report
> the picture?
>
> Thanks!
Carsten has applied the patch.
Leo
--
Oracle is the new evil
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [BUG] org splitting window weird layout
2011-02-12 16:59 ` Leo
@ 2011-02-12 17:11 ` Bastien
0 siblings, 0 replies; 4+ messages in thread
From: Bastien @ 2011-02-12 17:11 UTC (permalink / raw)
To: Leo; +Cc: emacs-orgmode
Leo <sdl.web@gmail.com> writes:
> Carsten has applied the patch.
Thanks for confirming.
--
Bastien
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2011-02-12 17:11 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-12-09 10:43 [BUG] org splitting window weird layout Leo
2011-02-12 14:41 ` Bastien
2011-02-12 16:59 ` Leo
2011-02-12 17:11 ` Bastien
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).