emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
* [PATCH] Tiny patch for org-agenda.el
@ 2010-02-16 23:59 Peter Povinec
  2010-02-17  7:27 ` Carsten Dominik
  0 siblings, 1 reply; 2+ messages in thread
From: Peter Povinec @ 2010-02-16 23:59 UTC (permalink / raw)
  To: emacs-orgmode

Hi Carsten,

I found that org-search-view doesn't allow one to search only within headlines
for individual words unless org-agenda-search-view-search-words-only is set. 
This appears to be due to a bug in the string argument processing which the
following tiny patch rectifies.  

Thanks,
--Peter


Changelog entry:
2010-02-16  Peter Povinec  <ppovinec@gmail.com>

	* org-agenda.el (org-search-view): Need to check 'words', not 'string', to
determine if individual word matching is requested.

Patch (the original file is from org-6.34c):

*** org-agenda.el       Tue Feb 16 15:54:53 2010
--- org-agenda.new.el   Tue Feb 16 15:53:39 2010
***************
*** 3322,3328 ****
        (setq full-words t
            words (substring words 1)))
      (if (or org-agenda-search-view-always-boolean
!           (member (string-to-char string) '(?- ?+ ?\{)))
        (setq boolean t))
      (setq words (org-split-string words))
      (setq org-agenda-last-search-view-search-was-boolean boolean)
--- 3322,3328 ----
        (setq full-words t
            words (substring words 1)))
      (if (or org-agenda-search-view-always-boolean
!           (member (string-to-char words) '(?- ?+ ?\{)))
        (setq boolean t))
      (setq words (org-split-string words))
      (setq org-agenda-last-search-view-search-was-boolean boolean)



 

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] Tiny patch for org-agenda.el
  2010-02-16 23:59 [PATCH] Tiny patch for org-agenda.el Peter Povinec
@ 2010-02-17  7:27 ` Carsten Dominik
  0 siblings, 0 replies; 2+ messages in thread
From: Carsten Dominik @ 2010-02-17  7:27 UTC (permalink / raw)
  To: Peter Povinec; +Cc: emacs-orgmode

Indeed, thanks for the patch, I have applied it.

- Carsten

On Feb 17, 2010, at 12:59 AM, Peter Povinec wrote:

> Hi Carsten,
>
> I found that org-search-view doesn't allow one to search only within  
> headlines
> for individual words unless org-agenda-search-view-search-words-only  
> is set.
> This appears to be due to a bug in the string argument processing  
> which the
> following tiny patch rectifies.
>
> Thanks,
> --Peter
>
>
> Changelog entry:
> 2010-02-16  Peter Povinec  <ppovinec@gmail.com>
>
> 	* org-agenda.el (org-search-view): Need to check 'words', not  
> 'string', to
> determine if individual word matching is requested.
>
> Patch (the original file is from org-6.34c):
>
> *** org-agenda.el       Tue Feb 16 15:54:53 2010
> --- org-agenda.new.el   Tue Feb 16 15:53:39 2010
> ***************
> *** 3322,3328 ****
>        (setq full-words t
>            words (substring words 1)))
>      (if (or org-agenda-search-view-always-boolean
> !           (member (string-to-char string) '(?- ?+ ?\{)))
>        (setq boolean t))
>      (setq words (org-split-string words))
>      (setq org-agenda-last-search-view-search-was-boolean boolean)
> --- 3322,3328 ----
>        (setq full-words t
>            words (substring words 1)))
>      (if (or org-agenda-search-view-always-boolean
> !           (member (string-to-char words) '(?- ?+ ?\{)))
>        (setq boolean t))
>      (setq words (org-split-string words))
>      (setq org-agenda-last-search-view-search-was-boolean boolean)
>
>
>
>
>
>
>
> _______________________________________________
> Emacs-orgmode mailing list
> Please use `Reply All' to send replies to the list.
> Emacs-orgmode@gnu.org
> http://lists.gnu.org/mailman/listinfo/emacs-orgmode

- Carsten

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2010-02-17  7:27 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-02-16 23:59 [PATCH] Tiny patch for org-agenda.el Peter Povinec
2010-02-17  7:27 ` Carsten Dominik

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).