From mboxrd@z Thu Jan 1 00:00:00 1970 From: Carsten Dominik Subject: Re: [PATCH] Tiny patch for org-agenda.el Date: Wed, 17 Feb 2010 08:27:28 +0100 Message-ID: References: Mime-Version: 1.0 (Apple Message framework v936) Content-Type: text/plain; charset=US-ASCII; format=flowed; delsp=yes Content-Transfer-Encoding: 7bit Return-path: Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NheJv-0003p2-BQ for emacs-orgmode@gnu.org; Wed, 17 Feb 2010 02:27:39 -0500 Received: from [140.186.70.92] (port=52326 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NheJr-0003om-R5 for emacs-orgmode@gnu.org; Wed, 17 Feb 2010 02:27:37 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1NheJn-0002YP-GV for emacs-orgmode@gnu.org; Wed, 17 Feb 2010 02:27:34 -0500 Received: from mail-ew0-f228.google.com ([209.85.219.228]:36903) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1NheJn-0002YG-AF for emacs-orgmode@gnu.org; Wed, 17 Feb 2010 02:27:31 -0500 Received: by ewy28 with SMTP id 28so2402886ewy.8 for ; Tue, 16 Feb 2010 23:27:30 -0800 (PST) In-Reply-To: List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Peter Povinec Cc: emacs-orgmode@gnu.org Indeed, thanks for the patch, I have applied it. - Carsten On Feb 17, 2010, at 12:59 AM, Peter Povinec wrote: > Hi Carsten, > > I found that org-search-view doesn't allow one to search only within > headlines > for individual words unless org-agenda-search-view-search-words-only > is set. > This appears to be due to a bug in the string argument processing > which the > following tiny patch rectifies. > > Thanks, > --Peter > > > Changelog entry: > 2010-02-16 Peter Povinec > > * org-agenda.el (org-search-view): Need to check 'words', not > 'string', to > determine if individual word matching is requested. > > Patch (the original file is from org-6.34c): > > *** org-agenda.el Tue Feb 16 15:54:53 2010 > --- org-agenda.new.el Tue Feb 16 15:53:39 2010 > *************** > *** 3322,3328 **** > (setq full-words t > words (substring words 1))) > (if (or org-agenda-search-view-always-boolean > ! (member (string-to-char string) '(?- ?+ ?\{))) > (setq boolean t)) > (setq words (org-split-string words)) > (setq org-agenda-last-search-view-search-was-boolean boolean) > --- 3322,3328 ---- > (setq full-words t > words (substring words 1))) > (if (or org-agenda-search-view-always-boolean > ! (member (string-to-char words) '(?- ?+ ?\{))) > (setq boolean t)) > (setq words (org-split-string words)) > (setq org-agenda-last-search-view-search-was-boolean boolean) > > > > > > > > _______________________________________________ > Emacs-orgmode mailing list > Please use `Reply All' to send replies to the list. > Emacs-orgmode@gnu.org > http://lists.gnu.org/mailman/listinfo/emacs-orgmode - Carsten