From: Zelphir Kaltstahl <zelphirkaltstahl@posteo.de>
To: Ihor Radchenko <yantar92@posteo.net>
Cc: Bruno Barbier <brubar.cs@gmail.com>,
emacs-orgmode@gnu.org, Daniel Kraus <daniel@kraus.my>,
Bastien <bzg@gnu.org>
Subject: Re: org-babel guile source block bug in handling multiple values
Date: Fri, 10 Mar 2023 10:45:21 +0000 [thread overview]
Message-ID: <e2d6d327-9d65-1ee2-e9e8-0bb2347401f2@posteo.de> (raw)
In-Reply-To: <87pm9ioyrg.fsf@localhost>
[-- Attachment #1: Type: text/plain, Size: 1858 bytes --]
On 3/9/23 14:11, Ihor Radchenko wrote:
> Zelphir Kaltstahl<zelphirkaltstahl@posteo.de> writes:
>
>> OK, to wrap up (ha!), I want to ask:
>>
>> (q1) What is a rationale, if any, behind the let-wrapping?
> It makes sense in ob-emacs-lisp to not litter global Emacs state.
> In other ob-* lisp backends, I am not sure.
> I am CCing Daniel, the maintainer of ob-clojure (we have no active
> maintainer for ob-scheme now). Maybe, Daniel has some useful insight.
>
>> (q2) Any chances of that changing to (define ...)?
> This sounds reasonable.
>
>> (q3) How could I change my org-mode's code to not let-wrap, and instead use
>> (define ...)?
> See `org-babel-expand-body:scheme'. You can re-define it for a quick
> temporary fix.
Thanks for the hint!
Here is my fix for my init.el:
~~~~START~~~~
;; Redefine/override org-babel-expand-body:scheme to avoid
;; let-wrapping with :var header args in source blocks.
(defun xiaolong/org-babel-format-vars (vars)
"Format :var header arguments given as VARS."
(mapconcat (lambda (var)
(format "(define %s %S)" (car var) (cdr var)))
vars
"\n"))
(eval-after-load "org"
'(defun org-babel-expand-body:scheme (body params)
"Expand BODY according to PARAMS, return the expanded body."
(let ((vars (org-babel--get-vars params))
(prepends (cdr (assq :prologue params)))
(postpends (cdr (assq :epilogue params))))
(concat (and prepends (concat prepends "\n"))
(if (null vars)
body
(concat (xiaolong/org-babel-format-vars vars) body))
(and postpends (concat "\n" postpends))))))
~~~~~END~~~~~
That was simpler than I expected and the first time I overrode anything of
org-mode =)
Regards,
Zelphir
--
repositories:https://notabug.org/ZelphirKaltstahl
[-- Attachment #2: Type: text/html, Size: 2872 bytes --]
next prev parent reply other threads:[~2023-03-10 10:46 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-07 11:27 org-babel guile source block bug in handling multiple values Zelphir Kaltstahl
2023-03-07 14:36 ` Ihor Radchenko
2023-03-07 15:18 ` Zelphir Kaltstahl
2023-03-07 19:52 ` Bruno Barbier
2023-03-08 0:55 ` Zelphir Kaltstahl
2023-03-08 19:38 ` Bruno Barbier
2023-03-09 0:44 ` Zelphir Kaltstahl
2023-03-09 13:04 ` [BUG] Inconsistent global/local :var assignments in ob-* for lisps and non-lisps (was: org-babel guile source block bug in handling multiple values) Ihor Radchenko
2023-03-10 10:39 ` Zelphir Kaltstahl
2023-03-11 9:58 ` Ihor Radchenko
2023-03-11 18:30 ` Zelphir Kaltstahl
2023-03-12 11:33 ` Ihor Radchenko
2023-03-19 13:50 ` [PATCH] lisp/ob-scheme.el Zelphir Kaltstahl
2023-03-22 10:43 ` Ihor Radchenko
2023-03-25 14:34 ` Zelphir Kaltstahl
2023-03-26 9:32 ` Ihor Radchenko
2023-04-25 12:28 ` Ihor Radchenko
2023-04-29 11:08 ` Zelphir Kaltstahl
2023-03-09 13:10 ` org-babel guile source block bug in handling multiple values Ihor Radchenko
2023-03-10 10:42 ` Zelphir Kaltstahl
2023-03-11 10:18 ` Ihor Radchenko
2023-06-02 13:11 ` Ihor Radchenko
2023-03-09 13:11 ` Ihor Radchenko
2023-03-09 14:21 ` Daniel Kraus
2023-03-10 11:57 ` Ihor Radchenko
2023-03-10 10:45 ` Zelphir Kaltstahl [this message]
2023-03-08 1:13 ` Zelphir Kaltstahl
2023-03-08 8:55 ` Ihor Radchenko
2023-03-07 15:44 ` Max Nikulin
2023-03-07 21:41 ` Rudolf Adamkovič
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e2d6d327-9d65-1ee2-e9e8-0bb2347401f2@posteo.de \
--to=zelphirkaltstahl@posteo.de \
--cc=brubar.cs@gmail.com \
--cc=bzg@gnu.org \
--cc=daniel@kraus.my \
--cc=emacs-orgmode@gnu.org \
--cc=yantar92@posteo.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).