emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: "Charles C. Berry" <ccberry@ucsd.edu>
To: Aaron Ecay <aaronecay@gmail.com>
Cc: Org-Mode mailing list <emacs-orgmode@gnu.org>
Subject: Re: [PATCH][BUG] org-babel-confirm-evaluate
Date: Sat, 7 Nov 2015 10:13:17 -0800	[thread overview]
Message-ID: <alpine.OSX.2.20.1511071001320.2226@charles-berrys-macbook.local> (raw)
In-Reply-To: <87twoyt79d.fsf@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 977 bytes --]

On Sat, 7 Nov 2015, Aaron Ecay wrote:

> Hi Chuck,
>
> The patch is fundamentally correct, please push it.  A couple minor
> comments:
>

Thanks for the comments. I've revised as suggested. The patch has been 
pushed as

   commit 3f6e71e62e558f4a1c4316c9ecf0519a905e87f3
   Author: Charles Berry <ccberry@ucsd.edu>
   Date:   Fri Nov 6 16:00:50 2015 -0800


>
> PS Git gave me some strange errors about trailing whitespace when trying
> to apply your patch, until I converted it from DOS to Unix line
> endings.  I’ve never seen git do that before – I think it usually copes
> very well with different line ending styles.  Does anyone know what to
> do in this scenario?  Manually changing the line endings of the patch
> file seems hackish.

Strange.

I produced the patch on Mac OS X 10.11.1 with the usual

 	git format-patch master -o <path>

command line using

 	git version 2.4.9 (Apple Git-60)

and sent it as an email attachment using alpine as the client.

Chuck

  reply	other threads:[~2015-11-07 18:13 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-07  0:11 [PATCH][BUG] org-babel-confirm-evaluate Charles C. Berry
2015-11-07 10:48 ` Aaron Ecay
2015-11-07 18:13   ` Charles C. Berry [this message]
2015-11-07 21:36     ` Aaron Ecay

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.OSX.2.20.1511071001320.2226@charles-berrys-macbook.local \
    --to=ccberry@ucsd.edu \
    --cc=aaronecay@gmail.com \
    --cc=emacs-orgmode@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).