From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Charles C. Berry" <ccberry@ucsd.edu>
Subject: Re: [PATCH][BUG] org-babel-confirm-evaluate
Date: Sat, 7 Nov 2015 10:13:17 -0800
Message-ID: <alpine.OSX.2.20.1511071001320.2226@charles-berrys-macbook.local>
References: <alpine.OSX.2.20.1511061604510.2161@charles-berrys-macbook.local>
	<87twoyt79d.fsf@gmail.com>
Mime-Version: 1.0
Content-Type: multipart/mixed; BOUNDARY="0-403290078-1446919998=:2226"
Return-path: <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:48214)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ccberry@ucsd.edu>) id 1Zv7zc-0005oj-HP
	for emacs-orgmode@gnu.org; Sat, 07 Nov 2015 13:13:37 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ccberry@ucsd.edu>) id 1Zv7zX-0001uK-H7
	for emacs-orgmode@gnu.org; Sat, 07 Nov 2015 13:13:36 -0500
Received: from iport-acv2-out.ucsd.edu ([132.239.0.174]:64365)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ccberry@ucsd.edu>) id 1Zv7zX-0001u7-8S
	for emacs-orgmode@gnu.org; Sat, 07 Nov 2015 13:13:31 -0500
In-Reply-To: <87twoyt79d.fsf@gmail.com>
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-orgmode>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
To: Aaron Ecay <aaronecay@gmail.com>
Cc: Org-Mode mailing list <emacs-orgmode@gnu.org>

  This message is in MIME format.  The first part should be readable text,
  while the remaining parts are likely unreadable without MIME-aware tools.

--0-403290078-1446919998=:2226
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8BIT

On Sat, 7 Nov 2015, Aaron Ecay wrote:

> Hi Chuck,
>
> The patch is fundamentally correct, please push it.  A couple minor
> comments:
>

Thanks for the comments. I've revised as suggested. The patch has been 
pushed as

   commit 3f6e71e62e558f4a1c4316c9ecf0519a905e87f3
   Author: Charles Berry <ccberry@ucsd.edu>
   Date:   Fri Nov 6 16:00:50 2015 -0800


>
> PS Git gave me some strange errors about trailing whitespace when trying
> to apply your patch, until I converted it from DOS to Unix line
> endings.  I’ve never seen git do that before – I think it usually copes
> very well with different line ending styles.  Does anyone know what to
> do in this scenario?  Manually changing the line endings of the patch
> file seems hackish.

Strange.

I produced the patch on Mac OS X 10.11.1 with the usual

 	git format-patch master -o <path>

command line using

 	git version 2.4.9 (Apple Git-60)

and sent it as an email attachment using alpine as the client.

Chuck
--0-403290078-1446919998=:2226--