org-refile, org-capture byte-compiling failure with recent emacs-git

org-refile, org-capture byte-compiling failure with recent emacs-git

[Vladimir Lomov]

[-- Attachment #1: Type: text/plain, Size: 1038 bytes --]

Hello,

org-refile and org-capture failed to byte-compile by emacs from git (commit:
8c8093aa6f20a7a4f3799cbdb9270cac013ef71d) with following messages:

...

Compiling /home/vladimir/pkgs/emacs-org-mode/src/emacs-org-mode/lisp/org-capture.el...

In toplevel form:
org-capture.el:1455:12: Error: Wrong number of arguments: (1 . 2), 4

...

Compiling /home/vladimir/pkgs/emacs-org-mode/src/emacs-org-mode/lisp/org-refile.el...

In toplevel form:
org-refile.el:566:17: Error: Wrong number of arguments: (1 . 2), 4

...

I also see this warning:

...

Compiling /home/vladimir/pkgs/emacs-org-mode/src/emacs-org-mode/lisp/org-agenda.el...
org-refile.el: Warning: Error: %S
org-refile.el: Warning: Error: %S

...

but not sure if it is related to above errors.

P.S. I tried the latest git commit (ef66660cf495b2bc6a4eb5b3c21e26d9df8c7577).

---
WBR, Vladimir Lomov

-- 
I come from a small town whose population never changed.  Each time a woman
got pregnant, someone left town.
		-- Michael Prichard

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

Re: org-refile, org-capture byte-compiling failure with recent emacs-git

[Kyle Meyer]

Vladimir Lomov writes:

> Hello,
>
> org-refile and org-capture failed to byte-compile by emacs from git (commit:
> 8c8093aa6f20a7a4f3799cbdb9270cac013ef71d) with following messages:
>
> ...
>
> Compiling /home/vladimir/pkgs/emacs-org-mode/src/emacs-org-mode/lisp/org-capture.el...
>
> In toplevel form:
> org-capture.el:1455:12: Error: Wrong number of arguments: (1 . 2), 4
>
> ...
>
> Compiling /home/vladimir/pkgs/emacs-org-mode/src/emacs-org-mode/lisp/org-refile.el...
>
> In toplevel form:
> org-refile.el:566:17: Error: Wrong number of arguments: (1 . 2), 4

Thanks for reporting.

I'll need to look more closely, but this is very likely triggered by
d52c929e31f ((with-demoted-errors): Warn on missing `format` arg,
2022-02-04) on Emacs's side.  That commit is slated to be ported to the
Org repo but has been held for the time being with the rest of the
Org-touching commits that are in Emacs's master branch but not the
emacs-28 branch.

In d52c929e31f, the with-demoted-errors calls in org-refile and
org-capture were changed to use the format argument, which has been
available since Emacs 24.4.  So, the likely fix will just be porting
that commit.  However, it seems unintended that with-demoted-errors
would actually error here now rather than give a warning; again, will
need to take a closer look.

Re: org-refile, org-capture byte-compiling failure with recent emacs-git

[Kyle Meyer]

Kyle Meyer writes:

> However, it seems unintended that with-demoted-errors would actually
> error here now rather than give a warning; again, will need to take a
> closer look.

The patch at <https://debbugs.gnu.org/54225> demotes the error to the
intended warning.

Re: org-refile, org-capture byte-compiling failure with recent emacs-git

[Kyle Meyer]

Kyle Meyer writes:

> Kyle Meyer writes:
>
>> However, it seems unintended that with-demoted-errors would actually
>> error here now rather than give a warning; again, will need to take a
>> closer look.
>
> The patch at <https://debbugs.gnu.org/54225> demotes the error to the
> intended warning.

And Emacs's d52c929e3 has been ported to Org's bugfix branch to avoid
these failures regardless of whether the patch there is applied.

Re: org-refile, org-capture byte-compiling failure with recent emacs-git

[Vladimir Lomov]

[-- Attachment #1: Type: text/plain, Size: 754 bytes --]

Hello,
** Kyle Meyer <kyle@kyleam.com> [2022-03-02 23:11:53 -0500]:

> Kyle Meyer writes:

>> Kyle Meyer writes:
>>
>>> However, it seems unintended that with-demoted-errors would actually
>>> error here now rather than give a warning; again, will need to take a
>>> closer look.
>>
>> The patch at <https://debbugs.gnu.org/54225> demotes the error to the
>> intended warning.

> And Emacs's d52c929e3 has been ported to Org's bugfix branch to avoid
> these failures regardless of whether the patch there is applied.

Thank you Kyle, commit 91681fc03 compiles fine.

---
WBR, Vladimir Lomov

-- 
Nearly every complex solution to a programming problem that I
have looked at carefully has turned out to be wrong.
		-- Brent Welch

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]