[BUG] Org 9.6 Inactive timestamp search no longer works as expected.

[BUG] Org 9.6 Inactive timestamp search no longer works as expected.

[Carlo Tambuatco]

Simple inactive timestamp search for recent completed tasks used to return as expected. ie:

+TIMESTAMP_IA>=“<today>”+TIMESTAMP_IA<“<tomorrow>” 

would return all tasks that I completed today. (Had an inactive timestamp greater than or equal 
to 12:00 am of the current day, but less than tomorrow)

Now it returns nothing.

Running just +TIMESTAMP_IA>=“<today>” gives me a bunch of tasks with timestamps 
less than today. Pretty much every timestamp that is less than today, which is huge.

Pretty much the opposite of what you would expect it to return.


Am reverting back to Org 9.5.5 until this issue is resolved.

Re: [BUG] Org 9.6 Inactive timestamp search no longer works as expected.

[Kyle Meyer]

On 12/03/22 13:44:33 -0500, Carlo Tambuatco wrote:
> Simple inactive timestamp search for recent completed tasks used to return as expected. ie:
>
> +TIMESTAMP_IA>=“<today>”+TIMESTAMP_IA<“<tomorrow>” 
>
> would return all tasks that I completed today. (Had an inactive timestamp greater than or equal 
> to 12:00 am of the current day, but less than tomorrow)
> [...]

Thanks for reporting.  I had noticed one of my "<now>" queries had
stopped working but hadn't yet got around to bisecting.  Doing so now,
this looks like a regression from e022a0cea (org-make-tags-matcher: Do
not treat PROPERTY="[X]" as timestamp match, 2022-10-25).

Ihor, I haven't reviewed the linked discussion in that commit, but with
its change (shown below), the regex now longer matches things like
"<today>" and "<now>".

diff --git a/lisp/org.el b/lisp/org.el
index e93a81210..01e0279c8 100644
--- a/lisp/org.el
+++ b/lisp/org.el
@@ -11337,7 +11337,7 @@ (defun org-make-tags-matcher (match &optional only-local-tags)
 			     (pv (match-string 7 term))
 			     (regexp (eq (string-to-char pv) ?{))
 			     (strp (eq (string-to-char pv) ?\"))
-			     (timep (string-match-p "^\"[[<].*[]>]\"$" pv))
+			     (timep (string-match-p "^\"[[<][0-9]+.*[]>]\"$" pv))
 			     (po (org-op-to-function (match-string 6 term)
 						     (if timep 'time strp))))
 			(setq pv (if (or regexp strp) (substring pv 1 -1) pv))

Re: [BUG] Org 9.6 Inactive timestamp search no longer works as expected.

[Ihor Radchenko]

Kyle Meyer <kyle@kyleam.com> writes:

> On 12/03/22 13:44:33 -0500, Carlo Tambuatco wrote:
>> Simple inactive timestamp search for recent completed tasks used to return as expected. ie:
>>
>> +TIMESTAMP_IA>=“<today>”+TIMESTAMP_IA<“<tomorrow>” 
>>
>> would return all tasks that I completed today. (Had an inactive timestamp greater than or equal 
>> to 12:00 am of the current day, but less than tomorrow)
>> [...]
>
> Thanks for reporting.  I had noticed one of my "<now>" queries had
> stopped working but hadn't yet got around to bisecting.  Doing so now,
> this looks like a regression from e022a0cea (org-make-tags-matcher: Do
> not treat PROPERTY="[X]" as timestamp match, 2022-10-25).
>
> Ihor, I haven't reviewed the linked discussion in that commit, but with
> its change (shown below), the regex now longer matches things like
> "<today>" and "<now>".
>
> diff --git a/lisp/org.el b/lisp/org.el
> index e93a81210..01e0279c8 100644
> --- a/lisp/org.el
> +++ b/lisp/org.el
> @@ -11337,7 +11337,7 @@ (defun org-make-tags-matcher (match &optional only-local-tags)
>  			     (pv (match-string 7 term))
>  			     (regexp (eq (string-to-char pv) ?{))
>  			     (strp (eq (string-to-char pv) ?\"))
> -			     (timep (string-match-p "^\"[[<].*[]>]\"$" pv))
> +			     (timep (string-match-p "^\"[[<][0-9]+.*[]>]\"$" pv))

Thanks for the bisection!
The problematic commit tried to fix false positive matches of the
regexp. I overdid it.

Fixed on bugfix now.
https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=5d14e88c5

-- 
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>