* [BUG] Org 9.6 Inactive timestamp search no longer works as expected.
@ 2022-12-03 18:44 Carlo Tambuatco
2022-12-03 19:49 ` Kyle Meyer
0 siblings, 1 reply; 3+ messages in thread
From: Carlo Tambuatco @ 2022-12-03 18:44 UTC (permalink / raw)
To: Org-Mode Mailing List
Simple inactive timestamp search for recent completed tasks used to return as expected. ie:
+TIMESTAMP_IA>=“<today>”+TIMESTAMP_IA<“<tomorrow>”
would return all tasks that I completed today. (Had an inactive timestamp greater than or equal
to 12:00 am of the current day, but less than tomorrow)
Now it returns nothing.
Running just +TIMESTAMP_IA>=“<today>” gives me a bunch of tasks with timestamps
less than today. Pretty much every timestamp that is less than today, which is huge.
Pretty much the opposite of what you would expect it to return.
Am reverting back to Org 9.5.5 until this issue is resolved.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [BUG] Org 9.6 Inactive timestamp search no longer works as expected.
2022-12-03 18:44 [BUG] Org 9.6 Inactive timestamp search no longer works as expected Carlo Tambuatco
@ 2022-12-03 19:49 ` Kyle Meyer
2022-12-07 11:26 ` Ihor Radchenko
0 siblings, 1 reply; 3+ messages in thread
From: Kyle Meyer @ 2022-12-03 19:49 UTC (permalink / raw)
To: Carlo Tambuatco; +Cc: Org-Mode Mailing List, Ihor Radchenko
On 12/03/22 13:44:33 -0500, Carlo Tambuatco wrote:
> Simple inactive timestamp search for recent completed tasks used to return as expected. ie:
>
> +TIMESTAMP_IA>=“<today>”+TIMESTAMP_IA<“<tomorrow>”
>
> would return all tasks that I completed today. (Had an inactive timestamp greater than or equal
> to 12:00 am of the current day, but less than tomorrow)
> [...]
Thanks for reporting. I had noticed one of my "<now>" queries had
stopped working but hadn't yet got around to bisecting. Doing so now,
this looks like a regression from e022a0cea (org-make-tags-matcher: Do
not treat PROPERTY="[X]" as timestamp match, 2022-10-25).
Ihor, I haven't reviewed the linked discussion in that commit, but with
its change (shown below), the regex now longer matches things like
"<today>" and "<now>".
diff --git a/lisp/org.el b/lisp/org.el
index e93a81210..01e0279c8 100644
--- a/lisp/org.el
+++ b/lisp/org.el
@@ -11337,7 +11337,7 @@ (defun org-make-tags-matcher (match &optional only-local-tags)
(pv (match-string 7 term))
(regexp (eq (string-to-char pv) ?{))
(strp (eq (string-to-char pv) ?\"))
- (timep (string-match-p "^\"[[<].*[]>]\"$" pv))
+ (timep (string-match-p "^\"[[<][0-9]+.*[]>]\"$" pv))
(po (org-op-to-function (match-string 6 term)
(if timep 'time strp))))
(setq pv (if (or regexp strp) (substring pv 1 -1) pv))
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [BUG] Org 9.6 Inactive timestamp search no longer works as expected.
2022-12-03 19:49 ` Kyle Meyer
@ 2022-12-07 11:26 ` Ihor Radchenko
0 siblings, 0 replies; 3+ messages in thread
From: Ihor Radchenko @ 2022-12-07 11:26 UTC (permalink / raw)
To: Kyle Meyer; +Cc: Carlo Tambuatco, Org-Mode Mailing List
Kyle Meyer <kyle@kyleam.com> writes:
> On 12/03/22 13:44:33 -0500, Carlo Tambuatco wrote:
>> Simple inactive timestamp search for recent completed tasks used to return as expected. ie:
>>
>> +TIMESTAMP_IA>=“<today>”+TIMESTAMP_IA<“<tomorrow>”
>>
>> would return all tasks that I completed today. (Had an inactive timestamp greater than or equal
>> to 12:00 am of the current day, but less than tomorrow)
>> [...]
>
> Thanks for reporting. I had noticed one of my "<now>" queries had
> stopped working but hadn't yet got around to bisecting. Doing so now,
> this looks like a regression from e022a0cea (org-make-tags-matcher: Do
> not treat PROPERTY="[X]" as timestamp match, 2022-10-25).
>
> Ihor, I haven't reviewed the linked discussion in that commit, but with
> its change (shown below), the regex now longer matches things like
> "<today>" and "<now>".
>
> diff --git a/lisp/org.el b/lisp/org.el
> index e93a81210..01e0279c8 100644
> --- a/lisp/org.el
> +++ b/lisp/org.el
> @@ -11337,7 +11337,7 @@ (defun org-make-tags-matcher (match &optional only-local-tags)
> (pv (match-string 7 term))
> (regexp (eq (string-to-char pv) ?{))
> (strp (eq (string-to-char pv) ?\"))
> - (timep (string-match-p "^\"[[<].*[]>]\"$" pv))
> + (timep (string-match-p "^\"[[<][0-9]+.*[]>]\"$" pv))
Thanks for the bisection!
The problematic commit tried to fix false positive matches of the
regexp. I overdid it.
Fixed on bugfix now.
https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=5d14e88c5
--
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-12-07 11:27 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-12-03 18:44 [BUG] Org 9.6 Inactive timestamp search no longer works as expected Carlo Tambuatco
2022-12-03 19:49 ` Kyle Meyer
2022-12-07 11:26 ` Ihor Radchenko
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).