emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
* In-buffer completion
@ 2010-11-20 14:26 Carsten Dominik
  2010-11-20 17:50 ` Dan Davison
  0 siblings, 1 reply; 5+ messages in thread
From: Carsten Dominik @ 2010-11-20 14:26 UTC (permalink / raw)
  To: Org Mode; +Cc: John Wiegley

Dear all,

yesterday I replaced the previous implementation of
in-buffer completion (M-TAB of Esc TAB) with a new
function making use of John Wiegleys pcomplete.el.
In fact, John did most of the Org-related implementation
already months ago - I only tied up some loose ends.

So if you are noticing something unexpected in
in-buffer completion, this is the cause.  There may
be bugs, if you find any, let me know.

Most importantly, however, in-buffer completion is now
implement so much cleaner, and we can extend it if we
want.  So if you have good ideas where in-buffer completion
would be useful and does not work already, lets hear it!

Thanks to John for yet another great addition to Org mode.

- Carsten

^ permalink raw reply	[flat|nested] 5+ messages in thread
* Re: In-buffer completion
  2010-11-20 14:26 In-buffer completion Carsten Dominik
@ 2010-11-20 17:50 ` Dan Davison
  2010-11-20 19:16   ` Carsten Dominik
  2010-11-23 14:12   ` [Accepted] " Carsten Dominik
  0 siblings, 2 replies; 5+ messages in thread
From: Dan Davison @ 2010-11-20 17:50 UTC (permalink / raw)
  To: Carsten Dominik; +Cc: John Wiegley, Org Mode

Carsten Dominik <carsten.dominik@gmail.com> writes:

> Dear all,
>
> yesterday I replaced the previous implementation of
> in-buffer completion (M-TAB of Esc TAB) with a new
> function making use of John Wiegleys pcomplete.el.
> In fact, John did most of the Org-related implementation
> already months ago - I only tied up some loose ends.
>
> So if you are noticing something unexpected in
> in-buffer completion, this is the cause.  There may
> be bugs, if you find any, let me know.
>
> Most importantly, however, in-buffer completion is now
> implement so much cleaner, and we can extend it if we
> want.  So if you have good ideas where in-buffer completion
> would be useful and does not work already, lets hear it!

Hi Carsten,

That looks nice. Here's a few #+ keywords I notice are
missing. (Shouldn't more of these entries have a terminal colon?)

Dan

diff --git a/lisp/org.el b/lisp/org.el
index c634a6c..917a368 100644
--- a/lisp/org.el
+++ b/lisp/org.el
@@ -10547,9 +10547,14 @@ This function can be used in a hook."
     "BEGIN_VERSE" "END_VERSE"
     "BEGIN_CENTER" "END_CENTER"
     "BEGIN_SRC" "END_SRC"
+    "SOURCE:" "SRCNAME:" "FUNCTION:"
+    "RESULTS:"
+    "HEADER:" "HEADERS:"
+    "BABEL:"
     "CATEGORY" "COLUMNS" "PROPERTY"
     "CAPTION" "LABEL"
     "SETUPFILE"
+    "INCLUDE:"
     "BIND"
     "MACRO"))



>
> Thanks to John for yet another great addition to Org mode.
>
> - Carsten
>
> _______________________________________________
> Emacs-orgmode mailing list
> Please use `Reply All' to send replies to the list.
> Emacs-orgmode@gnu.org
> http://lists.gnu.org/mailman/listinfo/emacs-orgmode

^ permalink raw reply related	[flat|nested] 5+ messages in thread
* Re: In-buffer completion
  2010-11-20 17:50 ` Dan Davison
@ 2010-11-20 19:16   ` Carsten Dominik
  2010-11-23 14:12   ` [Accepted] " Carsten Dominik
  1 sibling, 0 replies; 5+ messages in thread
From: Carsten Dominik @ 2010-11-20 19:16 UTC (permalink / raw)
  To: Dan Davison; +Cc: John Wiegley, Org Mode


On Nov 20, 2010, at 6:50 PM, Dan Davison wrote:

> Carsten Dominik <carsten.dominik@gmail.com> writes:
>
>> Dear all,
>>
>> yesterday I replaced the previous implementation of
>> in-buffer completion (M-TAB of Esc TAB) with a new
>> function making use of John Wiegleys pcomplete.el.
>> In fact, John did most of the Org-related implementation
>> already months ago - I only tied up some loose ends.
>>
>> So if you are noticing something unexpected in
>> in-buffer completion, this is the cause.  There may
>> be bugs, if you find any, let me know.
>>
>> Most importantly, however, in-buffer completion is now
>> implement so much cleaner, and we can extend it if we
>> want.  So if you have good ideas where in-buffer completion
>> would be useful and does not work already, lets hear it!
>
> Hi Carsten,
>
> That looks nice. Here's a few #+ keywords I notice are
> missing. (Shouldn't more of these entries have a terminal colon?)

I think you are right....

- Carsten

>
> Dan
>
> diff --git a/lisp/org.el b/lisp/org.el
> index c634a6c..917a368 100644
> --- a/lisp/org.el
> +++ b/lisp/org.el
> @@ -10547,9 +10547,14 @@ This function can be used in a hook."
>     "BEGIN_VERSE" "END_VERSE"
>     "BEGIN_CENTER" "END_CENTER"
>     "BEGIN_SRC" "END_SRC"
> +    "SOURCE:" "SRCNAME:" "FUNCTION:"
> +    "RESULTS:"
> +    "HEADER:" "HEADERS:"
> +    "BABEL:"
>     "CATEGORY" "COLUMNS" "PROPERTY"
>     "CAPTION" "LABEL"
>     "SETUPFILE"
> +    "INCLUDE:"
>     "BIND"
>     "MACRO"))
>
>
>
>>
>> Thanks to John for yet another great addition to Org mode.
>>
>> - Carsten
>>
>> _______________________________________________
>> Emacs-orgmode mailing list
>> Please use `Reply All' to send replies to the list.
>> Emacs-orgmode@gnu.org
>> http://lists.gnu.org/mailman/listinfo/emacs-orgmode

^ permalink raw reply	[flat|nested] 5+ messages in thread
* [Accepted] Re: In-buffer completion
  2010-11-20 17:50 ` Dan Davison
  2010-11-20 19:16   ` Carsten Dominik
@ 2010-11-23 14:12   ` Carsten Dominik
  2010-11-25 21:35     ` Dan Davison
  1 sibling, 1 reply; 5+ messages in thread
From: Carsten Dominik @ 2010-11-23 14:12 UTC (permalink / raw)
  To: emacs-orgmode

Patch 396 (http://patchwork.newartisans.com/patch/396/) is now "Accepted".

Maintainer comment: No comment

This relates to the following submission:

http://mid.gmane.org/%3C874obblwa8.fsf%40gmail.com%3E

Here is the original message containing the patch:

> Content-Type: text/plain; charset="utf-8"
> MIME-Version: 1.0
> Content-Transfer-Encoding: 7bit
> Subject: [Orgmode] Re: In-buffer completion
> Date: Sat, 20 Nov 2010 22:50:07 -0000
> From: Dan Davison <dandavison7@gmail.com>
> X-Patchwork-Id: 396
> Message-Id: <874obblwa8.fsf@gmail.com>
> To: Carsten Dominik <carsten.dominik@gmail.com>
> Cc: John Wiegley <jwiegley@gmail.com>, Org Mode <emacs-orgmode@gnu.org>
> 
> Carsten Dominik <carsten.dominik@gmail.com> writes:
> 
> > Dear all,
> >
> > yesterday I replaced the previous implementation of
> > in-buffer completion (M-TAB of Esc TAB) with a new
> > function making use of John Wiegleys pcomplete.el.
> > In fact, John did most of the Org-related implementation
> > already months ago - I only tied up some loose ends.
> >
> > So if you are noticing something unexpected in
> > in-buffer completion, this is the cause.  There may
> > be bugs, if you find any, let me know.
> >
> > Most importantly, however, in-buffer completion is now
> > implement so much cleaner, and we can extend it if we
> > want.  So if you have good ideas where in-buffer completion
> > would be useful and does not work already, lets hear it!
> 
> Hi Carsten,
> 
> That looks nice. Here's a few #+ keywords I notice are
> missing. (Shouldn't more of these entries have a terminal colon?)
> 
> Dan
> 
> 
> 
> >
> > Thanks to John for yet another great addition to Org mode.
> >
> > - Carsten
> >
> > _______________________________________________
> > Emacs-orgmode mailing list
> > Please use `Reply All' to send replies to the list.
> > Emacs-orgmode@gnu.org
> > http://lists.gnu.org/mailman/listinfo/emacs-orgmode
> 
> 
> diff --git a/lisp/org.el b/lisp/org.el
> index c634a6c..917a368 100644
> --- a/lisp/org.el
> +++ b/lisp/org.el
> @@ -10547,9 +10547,14 @@ This function can be used in a hook."
>      "BEGIN_VERSE" "END_VERSE"
>      "BEGIN_CENTER" "END_CENTER"
>      "BEGIN_SRC" "END_SRC"
> +    "SOURCE:" "SRCNAME:" "FUNCTION:"
> +    "RESULTS:"
> +    "HEADER:" "HEADERS:"
> +    "BABEL:"
>      "CATEGORY" "COLUMNS" "PROPERTY"
>      "CAPTION" "LABEL"
>      "SETUPFILE"
> +    "INCLUDE:"
>      "BIND"
>      "MACRO"))
> 
> 

^ permalink raw reply	[flat|nested] 5+ messages in thread
* Re: [Accepted] Re: In-buffer completion
  2010-11-23 14:12   ` [Accepted] " Carsten Dominik
@ 2010-11-25 21:35     ` Dan Davison
  0 siblings, 0 replies; 5+ messages in thread
From: Dan Davison @ 2010-11-25 21:35 UTC (permalink / raw)
  To: Carsten Dominik; +Cc: emacs-orgmode

Hi Carsten, 

Here's another completion bug:

#+sou plot-fitted-mode

If I put point after the u of "#+sou" and hit M-TAB, I get

concat: Wrong type argument: char-or-string-p, nil

in `org-command-at-point'. The reason is that `thing' in that function
gets set equal to ("file-option") and so (downcase (cdr thing)) fails on
the nil cdr. I'm not sure what's supposed to happen here really, so over
to you.

Dan


Carsten Dominik <cdominik@newartisans.com> writes:

> Patch 396 (http://patchwork.newartisans.com/patch/396/) is now "Accepted".
>
> Maintainer comment: No comment
>
> This relates to the following submission:
>
> http://mid.gmane.org/%3C874obblwa8.fsf%40gmail.com%3E
>
> Here is the original message containing the patch:
>
>> Content-Type: text/plain; charset="utf-8"
>> MIME-Version: 1.0
>> Content-Transfer-Encoding: 7bit
>> Subject: [Orgmode] Re: In-buffer completion
>> Date: Sat, 20 Nov 2010 22:50:07 -0000
>> From: Dan Davison <dandavison7@gmail.com>
>> X-Patchwork-Id: 396
>> Message-Id: <874obblwa8.fsf@gmail.com>
>> To: Carsten Dominik <carsten.dominik@gmail.com>
>> Cc: John Wiegley <jwiegley@gmail.com>, Org Mode <emacs-orgmode@gnu.org>
>> 
>> Carsten Dominik <carsten.dominik@gmail.com> writes:
>> 
>> > Dear all,
>> >
>> > yesterday I replaced the previous implementation of
>> > in-buffer completion (M-TAB of Esc TAB) with a new
>> > function making use of John Wiegleys pcomplete.el.
>> > In fact, John did most of the Org-related implementation
>> > already months ago - I only tied up some loose ends.
>> >
>> > So if you are noticing something unexpected in
>> > in-buffer completion, this is the cause.  There may
>> > be bugs, if you find any, let me know.
>> >
>> > Most importantly, however, in-buffer completion is now
>> > implement so much cleaner, and we can extend it if we
>> > want.  So if you have good ideas where in-buffer completion
>> > would be useful and does not work already, lets hear it!
>> 
>> Hi Carsten,
>> 
>> That looks nice. Here's a few #+ keywords I notice are
>> missing. (Shouldn't more of these entries have a terminal colon?)
>> 
>> Dan
>> 
>> 
>> 
>> >
>> > Thanks to John for yet another great addition to Org mode.
>> >
>> > - Carsten
>> >
>> > _______________________________________________
>> > Emacs-orgmode mailing list
>> > Please use `Reply All' to send replies to the list.
>> > Emacs-orgmode@gnu.org
>> > http://lists.gnu.org/mailman/listinfo/emacs-orgmode
>> 
>> 
>> diff --git a/lisp/org.el b/lisp/org.el
>> index c634a6c..917a368 100644
>> --- a/lisp/org.el
>> +++ b/lisp/org.el
>> @@ -10547,9 +10547,14 @@ This function can be used in a hook."
>>      "BEGIN_VERSE" "END_VERSE"
>>      "BEGIN_CENTER" "END_CENTER"
>>      "BEGIN_SRC" "END_SRC"
>> +    "SOURCE:" "SRCNAME:" "FUNCTION:"
>> +    "RESULTS:"
>> +    "HEADER:" "HEADERS:"
>> +    "BABEL:"
>>      "CATEGORY" "COLUMNS" "PROPERTY"
>>      "CAPTION" "LABEL"
>>      "SETUPFILE"
>> +    "INCLUDE:"
>>      "BIND"
>>      "MACRO"))
>> 
>> 
>
> _______________________________________________
> Emacs-orgmode mailing list
> Please use `Reply All' to send replies to the list.
> Emacs-orgmode@gnu.org
> http://lists.gnu.org/mailman/listinfo/emacs-orgmode

^ permalink raw reply	[flat|nested] 5+ messages in thread
end of thread, other threads:[~2010-11-25 21:35 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-11-20 14:26 In-buffer completion Carsten Dominik
2010-11-20 17:50 ` Dan Davison
2010-11-20 19:16   ` Carsten Dominik
2010-11-23 14:12   ` [Accepted] " Carsten Dominik
2010-11-25 21:35     ` Dan Davison

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).