emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Dan Davison <dandavison7@gmail.com>
To: Carsten Dominik <carsten.dominik@gmail.com>
Cc: John Wiegley <jwiegley@gmail.com>, Org Mode <emacs-orgmode@gnu.org>
Subject: Re: In-buffer completion
Date: Sat, 20 Nov 2010 17:50:07 +0000	[thread overview]
Message-ID: <874obblwa8.fsf@gmail.com> (raw)
In-Reply-To: <E7BF6DF0-9DD4-45EA-970C-FDCB7CCCA5EF@gmail.com> (Carsten Dominik's message of "Sat, 20 Nov 2010 15:26:47 +0100")

Carsten Dominik <carsten.dominik@gmail.com> writes:

> Dear all,
>
> yesterday I replaced the previous implementation of
> in-buffer completion (M-TAB of Esc TAB) with a new
> function making use of John Wiegleys pcomplete.el.
> In fact, John did most of the Org-related implementation
> already months ago - I only tied up some loose ends.
>
> So if you are noticing something unexpected in
> in-buffer completion, this is the cause.  There may
> be bugs, if you find any, let me know.
>
> Most importantly, however, in-buffer completion is now
> implement so much cleaner, and we can extend it if we
> want.  So if you have good ideas where in-buffer completion
> would be useful and does not work already, lets hear it!

Hi Carsten,

That looks nice. Here's a few #+ keywords I notice are
missing. (Shouldn't more of these entries have a terminal colon?)

Dan

diff --git a/lisp/org.el b/lisp/org.el
index c634a6c..917a368 100644
--- a/lisp/org.el
+++ b/lisp/org.el
@@ -10547,9 +10547,14 @@ This function can be used in a hook."
     "BEGIN_VERSE" "END_VERSE"
     "BEGIN_CENTER" "END_CENTER"
     "BEGIN_SRC" "END_SRC"
+    "SOURCE:" "SRCNAME:" "FUNCTION:"
+    "RESULTS:"
+    "HEADER:" "HEADERS:"
+    "BABEL:"
     "CATEGORY" "COLUMNS" "PROPERTY"
     "CAPTION" "LABEL"
     "SETUPFILE"
+    "INCLUDE:"
     "BIND"
     "MACRO"))



>
> Thanks to John for yet another great addition to Org mode.
>
> - Carsten
>
> _______________________________________________
> Emacs-orgmode mailing list
> Please use `Reply All' to send replies to the list.
> Emacs-orgmode@gnu.org
> http://lists.gnu.org/mailman/listinfo/emacs-orgmode

  reply	other threads:[~2010-11-20 17:51 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-11-20 14:26 Carsten Dominik
2010-11-20 17:50 ` Dan Davison [this message]
2010-11-20 19:16   ` Carsten Dominik
2010-11-23 14:12   ` [Accepted] " Carsten Dominik
2010-11-25 21:35     ` Dan Davison

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=874obblwa8.fsf@gmail.com \
    --to=dandavison7@gmail.com \
    --cc=carsten.dominik@gmail.com \
    --cc=emacs-orgmode@gnu.org \
    --cc=jwiegley@gmail.com \
    --subject='Re: In-buffer completion' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Code repositories for project(s) associated with this inbox:

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).