Dear all, yesterday I replaced the previous implementation of in-buffer completion (M-TAB of Esc TAB) with a new function making use of John Wiegleys pcomplete.el. In fact, John did most of the Org-related implementation already months ago - I only tied up some loose ends. So if you are noticing something unexpected in in-buffer completion, this is the cause. There may be bugs, if you find any, let me know. Most importantly, however, in-buffer completion is now implement so much cleaner, and we can extend it if we want. So if you have good ideas where in-buffer completion would be useful and does not work already, lets hear it! Thanks to John for yet another great addition to Org mode. - Carsten
Carsten Dominik <carsten.dominik@gmail.com> writes: > Dear all, > > yesterday I replaced the previous implementation of > in-buffer completion (M-TAB of Esc TAB) with a new > function making use of John Wiegleys pcomplete.el. > In fact, John did most of the Org-related implementation > already months ago - I only tied up some loose ends. > > So if you are noticing something unexpected in > in-buffer completion, this is the cause. There may > be bugs, if you find any, let me know. > > Most importantly, however, in-buffer completion is now > implement so much cleaner, and we can extend it if we > want. So if you have good ideas where in-buffer completion > would be useful and does not work already, lets hear it! Hi Carsten, That looks nice. Here's a few #+ keywords I notice are missing. (Shouldn't more of these entries have a terminal colon?) Dan diff --git a/lisp/org.el b/lisp/org.el index c634a6c..917a368 100644 --- a/lisp/org.el +++ b/lisp/org.el @@ -10547,9 +10547,14 @@ This function can be used in a hook." "BEGIN_VERSE" "END_VERSE" "BEGIN_CENTER" "END_CENTER" "BEGIN_SRC" "END_SRC" + "SOURCE:" "SRCNAME:" "FUNCTION:" + "RESULTS:" + "HEADER:" "HEADERS:" + "BABEL:" "CATEGORY" "COLUMNS" "PROPERTY" "CAPTION" "LABEL" "SETUPFILE" + "INCLUDE:" "BIND" "MACRO")) > > Thanks to John for yet another great addition to Org mode. > > - Carsten > > _______________________________________________ > Emacs-orgmode mailing list > Please use `Reply All' to send replies to the list. > Emacs-orgmode@gnu.org > http://lists.gnu.org/mailman/listinfo/emacs-orgmode
On Nov 20, 2010, at 6:50 PM, Dan Davison wrote: > Carsten Dominik <carsten.dominik@gmail.com> writes: > >> Dear all, >> >> yesterday I replaced the previous implementation of >> in-buffer completion (M-TAB of Esc TAB) with a new >> function making use of John Wiegleys pcomplete.el. >> In fact, John did most of the Org-related implementation >> already months ago - I only tied up some loose ends. >> >> So if you are noticing something unexpected in >> in-buffer completion, this is the cause. There may >> be bugs, if you find any, let me know. >> >> Most importantly, however, in-buffer completion is now >> implement so much cleaner, and we can extend it if we >> want. So if you have good ideas where in-buffer completion >> would be useful and does not work already, lets hear it! > > Hi Carsten, > > That looks nice. Here's a few #+ keywords I notice are > missing. (Shouldn't more of these entries have a terminal colon?) I think you are right.... - Carsten > > Dan > > diff --git a/lisp/org.el b/lisp/org.el > index c634a6c..917a368 100644 > --- a/lisp/org.el > +++ b/lisp/org.el > @@ -10547,9 +10547,14 @@ This function can be used in a hook." > "BEGIN_VERSE" "END_VERSE" > "BEGIN_CENTER" "END_CENTER" > "BEGIN_SRC" "END_SRC" > + "SOURCE:" "SRCNAME:" "FUNCTION:" > + "RESULTS:" > + "HEADER:" "HEADERS:" > + "BABEL:" > "CATEGORY" "COLUMNS" "PROPERTY" > "CAPTION" "LABEL" > "SETUPFILE" > + "INCLUDE:" > "BIND" > "MACRO")) > > > >> >> Thanks to John for yet another great addition to Org mode. >> >> - Carsten >> >> _______________________________________________ >> Emacs-orgmode mailing list >> Please use `Reply All' to send replies to the list. >> Emacs-orgmode@gnu.org >> http://lists.gnu.org/mailman/listinfo/emacs-orgmode
Patch 396 (http://patchwork.newartisans.com/patch/396/) is now "Accepted". Maintainer comment: No comment This relates to the following submission: http://mid.gmane.org/%3C874obblwa8.fsf%40gmail.com%3E Here is the original message containing the patch: > Content-Type: text/plain; charset="utf-8" > MIME-Version: 1.0 > Content-Transfer-Encoding: 7bit > Subject: [Orgmode] Re: In-buffer completion > Date: Sat, 20 Nov 2010 22:50:07 -0000 > From: Dan Davison <dandavison7@gmail.com> > X-Patchwork-Id: 396 > Message-Id: <874obblwa8.fsf@gmail.com> > To: Carsten Dominik <carsten.dominik@gmail.com> > Cc: John Wiegley <jwiegley@gmail.com>, Org Mode <emacs-orgmode@gnu.org> > > Carsten Dominik <carsten.dominik@gmail.com> writes: > > > Dear all, > > > > yesterday I replaced the previous implementation of > > in-buffer completion (M-TAB of Esc TAB) with a new > > function making use of John Wiegleys pcomplete.el. > > In fact, John did most of the Org-related implementation > > already months ago - I only tied up some loose ends. > > > > So if you are noticing something unexpected in > > in-buffer completion, this is the cause. There may > > be bugs, if you find any, let me know. > > > > Most importantly, however, in-buffer completion is now > > implement so much cleaner, and we can extend it if we > > want. So if you have good ideas where in-buffer completion > > would be useful and does not work already, lets hear it! > > Hi Carsten, > > That looks nice. Here's a few #+ keywords I notice are > missing. (Shouldn't more of these entries have a terminal colon?) > > Dan > > > > > > > Thanks to John for yet another great addition to Org mode. > > > > - Carsten > > > > _______________________________________________ > > Emacs-orgmode mailing list > > Please use `Reply All' to send replies to the list. > > Emacs-orgmode@gnu.org > > http://lists.gnu.org/mailman/listinfo/emacs-orgmode > > > diff --git a/lisp/org.el b/lisp/org.el > index c634a6c..917a368 100644 > --- a/lisp/org.el > +++ b/lisp/org.el > @@ -10547,9 +10547,14 @@ This function can be used in a hook." > "BEGIN_VERSE" "END_VERSE" > "BEGIN_CENTER" "END_CENTER" > "BEGIN_SRC" "END_SRC" > + "SOURCE:" "SRCNAME:" "FUNCTION:" > + "RESULTS:" > + "HEADER:" "HEADERS:" > + "BABEL:" > "CATEGORY" "COLUMNS" "PROPERTY" > "CAPTION" "LABEL" > "SETUPFILE" > + "INCLUDE:" > "BIND" > "MACRO")) > >
Hi Carsten,
Here's another completion bug:
#+sou plot-fitted-mode
If I put point after the u of "#+sou" and hit M-TAB, I get
concat: Wrong type argument: char-or-string-p, nil
in `org-command-at-point'. The reason is that `thing' in that function
gets set equal to ("file-option") and so (downcase (cdr thing)) fails on
the nil cdr. I'm not sure what's supposed to happen here really, so over
to you.
Dan
Carsten Dominik <cdominik@newartisans.com> writes:
> Patch 396 (http://patchwork.newartisans.com/patch/396/) is now "Accepted".
>
> Maintainer comment: No comment
>
> This relates to the following submission:
>
> http://mid.gmane.org/%3C874obblwa8.fsf%40gmail.com%3E
>
> Here is the original message containing the patch:
>
>> Content-Type: text/plain; charset="utf-8"
>> MIME-Version: 1.0
>> Content-Transfer-Encoding: 7bit
>> Subject: [Orgmode] Re: In-buffer completion
>> Date: Sat, 20 Nov 2010 22:50:07 -0000
>> From: Dan Davison <dandavison7@gmail.com>
>> X-Patchwork-Id: 396
>> Message-Id: <874obblwa8.fsf@gmail.com>
>> To: Carsten Dominik <carsten.dominik@gmail.com>
>> Cc: John Wiegley <jwiegley@gmail.com>, Org Mode <emacs-orgmode@gnu.org>
>>
>> Carsten Dominik <carsten.dominik@gmail.com> writes:
>>
>> > Dear all,
>> >
>> > yesterday I replaced the previous implementation of
>> > in-buffer completion (M-TAB of Esc TAB) with a new
>> > function making use of John Wiegleys pcomplete.el.
>> > In fact, John did most of the Org-related implementation
>> > already months ago - I only tied up some loose ends.
>> >
>> > So if you are noticing something unexpected in
>> > in-buffer completion, this is the cause. There may
>> > be bugs, if you find any, let me know.
>> >
>> > Most importantly, however, in-buffer completion is now
>> > implement so much cleaner, and we can extend it if we
>> > want. So if you have good ideas where in-buffer completion
>> > would be useful and does not work already, lets hear it!
>>
>> Hi Carsten,
>>
>> That looks nice. Here's a few #+ keywords I notice are
>> missing. (Shouldn't more of these entries have a terminal colon?)
>>
>> Dan
>>
>>
>>
>> >
>> > Thanks to John for yet another great addition to Org mode.
>> >
>> > - Carsten
>> >
>> > _______________________________________________
>> > Emacs-orgmode mailing list
>> > Please use `Reply All' to send replies to the list.
>> > Emacs-orgmode@gnu.org
>> > http://lists.gnu.org/mailman/listinfo/emacs-orgmode
>>
>>
>> diff --git a/lisp/org.el b/lisp/org.el
>> index c634a6c..917a368 100644
>> --- a/lisp/org.el
>> +++ b/lisp/org.el
>> @@ -10547,9 +10547,14 @@ This function can be used in a hook."
>> "BEGIN_VERSE" "END_VERSE"
>> "BEGIN_CENTER" "END_CENTER"
>> "BEGIN_SRC" "END_SRC"
>> + "SOURCE:" "SRCNAME:" "FUNCTION:"
>> + "RESULTS:"
>> + "HEADER:" "HEADERS:"
>> + "BABEL:"
>> "CATEGORY" "COLUMNS" "PROPERTY"
>> "CAPTION" "LABEL"
>> "SETUPFILE"
>> + "INCLUDE:"
>> "BIND"
>> "MACRO"))
>>
>>
>
> _______________________________________________
> Emacs-orgmode mailing list
> Please use `Reply All' to send replies to the list.
> Emacs-orgmode@gnu.org
> http://lists.gnu.org/mailman/listinfo/emacs-orgmode