From: Bhavin Gandhi <firstname.lastname@example.org>
To: Ihor Radchenko <email@example.com>
Cc: firstname.lastname@example.org, Gustavo Barros <email@example.com>
Subject: Re: [PATCH] Re: Bug: Duplicate logbook entry for repeated tasks [9.4.6 (9.4.6-gab9f2a @ /home/gustavo/.emacs.d/elpa/org-9.4.6/)]
Date: Mon, 12 Jul 2021 23:20:17 +0530 [thread overview]
Message-ID: <CAOn=hbcMR5pBYGViXEtAiYZTWWLscs37bFLw7w+rApFGG1EeWQ@mail.gmail.com> (raw)
On Sun, 11 Jul 2021 at 06:59, Ihor Radchenko <firstname.lastname@example.org> wrote:
> You are right. I believe that I fixed the breakage in the attached
> patch. Also, I noticed that c67037 did not fix the original bug when
> state change requests interactive note.
Thanks! I tested your latest patch, and it is fixing both the original
issues which `c67037' solved as well as this one.
I was trying to understand your change. So, when we call
`org-agenda-todo', it calls `org-todo' which adds the
post-command-hook. This hook is supposed to run when `org-agenda-todo'
finishes, but instead of that we call it directly. This makes sure that
the change is recorded in `buffer-undo-list'.
Sorry if that's too much to ask, but why don't we need something similar
when org-log-note-how is 'note? Can you please help me understand that?
I tried reading org-add-log-note and org-store-log-note, but I think I'm
missing something basic here.
Also, should this line from org.el (org-store-log-note) be removed?
;; Don't add undo information when called from `org-agenda-todo'.
next prev parent reply other threads:[~2021-07-12 17:52 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-14 13:39 Bug: Duplicate logbook entry for repeated tasks [9.4.6 (9.4.6-gab9f2a @ /home/gustavo/.emacs.d/elpa/org-9.4.6/)] Gustavo Barros
2021-06-14 18:01 ` Bhavin Gandhi
2021-06-14 18:41 ` Gustavo Barros
2021-07-10 13:48 ` [PATCH] " Ihor Radchenko
2021-07-10 16:46 ` Gustavo Barros
2021-07-10 17:14 ` Bhavin Gandhi
2021-07-11 1:29 ` Ihor Radchenko
2021-07-11 5:40 ` Ihor Radchenko
2021-07-11 5:57 ` Ihor Radchenko
2021-07-12 17:50 ` Bhavin Gandhi [this message]
2021-07-13 2:55 ` [PATCH] " Carlo Tambuatco
2021-07-13 15:35 ` Alan Ristow
2021-07-13 18:08 ` Bhavin Gandhi
2021-07-17 13:51 ` Ihor Radchenko
2021-07-17 13:41 ` [PATCH] " Ihor Radchenko
2021-09-25 15:25 ` Bastien
2021-09-25 18:15 ` Gustavo Barros
2021-09-26 6:26 ` Bastien
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).