From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id SAiDNkKB7GBUNQAAgWs5BA (envelope-from ) for ; Mon, 12 Jul 2021 19:52:02 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id yNJaMkKB7GBwCQAAB5/wlQ (envelope-from ) for ; Mon, 12 Jul 2021 17:52:02 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 168DE1616B for ; Mon, 12 Jul 2021 19:52:02 +0200 (CEST) Received: from localhost ([::1]:34906 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m3064-0007oI-BF for larch@yhetil.org; Mon, 12 Jul 2021 13:52:00 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:56202) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m3054-0007Yw-RO for emacs-orgmode@gnu.org; Mon, 12 Jul 2021 13:50:58 -0400 Received: from mail-lf1-x132.google.com ([2a00:1450:4864:20::132]:42662) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1m3053-0004hi-3z for emacs-orgmode@gnu.org; Mon, 12 Jul 2021 13:50:58 -0400 Received: by mail-lf1-x132.google.com with SMTP id 8so33230816lfp.9 for ; Mon, 12 Jul 2021 10:50:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=NhOWQWPmsQeAcJceeVuxA5fZQNhQ2hVY44kNCFnwSpo=; b=MEDmlSZwVyz0PgaVAGtJ3k9riWUrXGZ9lLepeGzT5Z5Sz19pr81S4fLbU9RDSkkEZc +fVkhln8ME5kSTOReCrm3VpZ6kmT/0ndzVbhSlhhRXkHk+CDJ+9AdeQT+dnco+Lo3ZTR bxMYziqMUMdC+RE1FXrFBzm8reMWscEZXypQuOe0lCv0OrJW/bGkkKN2yCUSFDCrTSHg M0lWCg1cGIaNyIdfdqP/mD1ZuCY8SSEyikNrfDIOVAM/ELv2fA9ptUpikYgYbCgu7l+d H5Krn8+A/rtUdfEomkF4WlUtf5EaU0JwoQl23smrnweIG7qzd+xLCzuqh6StTwghuGQl LuzQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=NhOWQWPmsQeAcJceeVuxA5fZQNhQ2hVY44kNCFnwSpo=; b=fOWjKPWCkSAknEFg8YtsMndlGowQ7P2hPzXtvm0RbSIvP+AqQqv3pq+anSE19tF6Xn wkbm/VkcNpI/co5Y5GM+HjRKA50oautMaaT6JnA7xRIAAgnO914y4HIfmnhe5MppH6pU 5+YJgF9Y/uoka/gUwjH02TurbY9YU+dXDVv8whGXj0G0VhV59BqUeM8RxFCjScPtP3U+ gJvbNl+U9a/KfmaM83B9qi0RLmxFUmKeQeO6eiU3/7PIFX3LZtFMFP9flQwkglRpMlVF QLB/NS2QU4r7THLbRvOzsqK/PxhzLItzg7SDGj5eA71u8sR3eFaYrR533khHnrS7Pn06 /vIw== X-Gm-Message-State: AOAM532hOLeUIFJdJQQlq1ny9M3oQjhGfEfWrpBqVFMHMycsrCtymf79 VjaVTPoqNGrNdaSJdSlUtYYej2NcXyMeWWpcJgo= X-Google-Smtp-Source: ABdhPJwTAwMPCBnfylrHQsq+4yJSAE3rQ3VsZCSbwjbVUm7Eci5AlhcATq2dwZXf75uYNolgpEtYWyEjdQVuT4AELhA= X-Received: by 2002:a05:6512:2295:: with SMTP id f21mr31637947lfu.520.1626112254082; Mon, 12 Jul 2021 10:50:54 -0700 (PDT) MIME-Version: 1.0 References: <877diwbm6a.fsf@gmail.com> <87a6muwa93.fsf@localhost> <874kd1wsc6.fsf@localhost> <871r85wgqd.fsf@localhost> <87wnpxv1d8.fsf@localhost> In-Reply-To: <87wnpxv1d8.fsf@localhost> From: Bhavin Gandhi Date: Mon, 12 Jul 2021 23:20:17 +0530 Message-ID: Subject: Re: [PATCH] Re: Bug: Duplicate logbook entry for repeated tasks [9.4.6 (9.4.6-gab9f2a @ /home/gustavo/.emacs.d/elpa/org-9.4.6/)] To: Ihor Radchenko Content-Type: text/plain; charset="UTF-8" Received-SPF: pass client-ip=2a00:1450:4864:20::132; envelope-from=bhavin7392@gmail.com; helo=mail-lf1-x132.google.com X-Spam_score_int: -17 X-Spam_score: -1.8 X-Spam_bar: - X-Spam_report: (-1.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: emacs-orgmode@gnu.org, Gustavo Barros Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1626112322; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=NhOWQWPmsQeAcJceeVuxA5fZQNhQ2hVY44kNCFnwSpo=; b=hAmrjKq0MoNBtg3TI1xet315Nnp269DgBVp2alqz9QqC9AGpW08IeBkZ1PSJX7IkKxBt/y wMl2sz9T5Q1ChuBrUIdxhPO0ux05/AVuUotriT2wRigUoueRF2L/zCtz64eeJXzkrBlrPv 77wWtZDaukMnZs0rcSU9OGH0pwBXYGEXGCzDTlX/gehmITsuCBk17bVh04obbHzb8oKn2N RpsMd7cKdwtQ/OSH+Z0gst6A2PY0YWmGVg0ZJfeVWXlPKtPAXVlS7hwmmRMuCYUT7kHfgu +ycVkQRgBcKiRMRwpmDqghBEN9uODF+lX6ynYhL6FKtYv++OSdgl64ndQedXlQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1626112322; a=rsa-sha256; cv=none; b=T0KPhcA4cVIWRLcpLkJiXe5M6R/jFyLtfzM9ieZaIhZNslhRSZdf1U63FJIKgw8QbqvrGw YT4BnUKDc4TNQsz75xRwLY015SAVJRQANJMAysQJ2AV/WI3g8W4UsGEJz6UZKC0zUQIpEm Osv7bbdGCehwVeS8re+NN/CUT/LtUk91iYqUKSt27z/DqJ1asI9XIe7yPedVJ+7mWx4/+B SFCn6O9coU/xROfzrlZPEvsPoJp8K/6RmOunLX2EJo//ZGPZaad753TvEn8zRTtdGc4EN6 R1DSckV8/TCVw+8v65rIhj47bGXXtBA8eNNOe8DtFiOoDDi5NI8Nzo5llLq5ag== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20161025 header.b=MEDmlSZw; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Migadu-Spam-Score: -1.31 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20161025 header.b=MEDmlSZw; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Migadu-Queue-Id: 168DE1616B X-Spam-Score: -1.31 X-Migadu-Scanner: scn0.migadu.com X-TUID: KrhiKOu6pD8V On Sun, 11 Jul 2021 at 06:59, Ihor Radchenko wrote: > You are right. I believe that I fixed the breakage in the attached > patch. Also, I noticed that c67037 did not fix the original bug when > state change requests interactive note. Thanks! I tested your latest patch, and it is fixing both the original issues which `c67037' solved as well as this one. I was trying to understand your change. So, when we call `org-agenda-todo', it calls `org-todo' which adds the post-command-hook. This hook is supposed to run when `org-agenda-todo' finishes, but instead of that we call it directly. This makes sure that the change is recorded in `buffer-undo-list'. Sorry if that's too much to ask, but why don't we need something similar when org-log-note-how is 'note? Can you please help me understand that? I tried reading org-add-log-note and org-store-log-note, but I think I'm missing something basic here. Also, should this line from org.el (org-store-log-note) be removed? ;; Don't add undo information when called from `org-agenda-todo'.