emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Matt Price <moptop99@gmail.com>
To: "N. Raghavendra" <nyraghu27132@gmail.com>,
	Org Mode <emacs-orgmode@gnu.org>
Subject: Re: [PATCH] ox-html.el: Fix display of language indicators for source blocks
Date: Mon, 12 Jun 2017 12:45:13 -0400	[thread overview]
Message-ID: <CAN_Dec82iObXtxZ_KkAQXRU-HuuLyV6Eb=jWCLKxzeb3nKBwUw@mail.gmail.com> (raw)
In-Reply-To: <8737bap8px.fsf@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 1459 bytes --]

Hi,

You raise two important-seeming points about my patch:

1) a feature (display of language on hover) is removed by the patch
2) the patch also breaks XHTML validation

That patch was submitted to add support for live code examples in exported
HTML (using the klipse.js  library).  As it stands right now, both changes
(addition of `data-editor-type` attribute and moving the language name
class from `pre` to `code`) are necessary to make klipse work (cf.
https://github.com/viebel/klipse).  I'd rather not lose that functionality
completely. Can you think of a way to solve both the problems without
losing klipse funcitonality? If not, would you be satisfied with an
improved docstring and maybe turning klipse off by default?


On Thu, Jun 8, 2017 at 3:42 PM, N. Raghavendra <nyraghu27132@gmail.com>
wrote:

> At 2017-06-08T21:24:31+02:00, Nicolas Goaziou wrote:
>
> > I'm Cc'ing Matt Price, who introduced klipse feature, for some
> > insight.
>
> Thanks for the reply, and for the information.  I'll wait for Matt
> Price's response.
>
> > You posted the patch only two days ago. I hope you understand a "bump"
> > may be a bit early at this point.
>
> Certainly.  It was less a bump than an expression of concern that my
> messages may have been lost in the general mileu of the mailing list.
>
> Cheers,
> Raghu.
>
> --
> N. Raghavendra <raghu@hri.res.in>, http://www.retrotexts.net/
> Harish-Chandra Research Institute, http://www.hri.res.in/
>
>

[-- Attachment #2: Type: text/html, Size: 2270 bytes --]

  reply	other threads:[~2017-06-12 16:45 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-06 15:20 [PATCH] ox-html.el: Fix display of language indicators for source blocks N. Raghavendra
2017-06-06 20:08 ` N. Raghavendra
2017-06-08 18:57 ` N. Raghavendra
2017-06-08 19:24   ` Nicolas Goaziou
2017-06-08 19:42     ` N. Raghavendra
2017-06-12 16:45       ` Matt Price [this message]
2017-06-14 17:32         ` N. Raghavendra
2017-09-19  0:54           ` N. Raghavendra
2017-09-19 17:18             ` N. Raghavendra
2017-09-19 20:02               ` Nicolas Goaziou
2017-06-08 20:15     ` Matt Price

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAN_Dec82iObXtxZ_KkAQXRU-HuuLyV6Eb=jWCLKxzeb3nKBwUw@mail.gmail.com' \
    --to=moptop99@gmail.com \
    --cc=emacs-orgmode@gnu.org \
    --cc=nyraghu27132@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).