From mboxrd@z Thu Jan 1 00:00:00 1970 From: Matt Price Subject: Re: [PATCH] ox-html.el: Fix display of language indicators for source blocks Date: Mon, 12 Jun 2017 12:45:13 -0400 Message-ID: References: <8760g9ywga.fsf@hri.res.in> <87a85iparx.fsf@gmail.com> <87h8zq2sgg.fsf@nicolasgoaziou.fr> <8737bap8px.fsf@gmail.com> Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="001a114340100ca7a40551c60bb2" Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:34109) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dKSSs-00084n-71 for emacs-orgmode@gnu.org; Mon, 12 Jun 2017 12:45:20 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dKSSq-00069L-HG for emacs-orgmode@gnu.org; Mon, 12 Jun 2017 12:45:18 -0400 Received: from mail-qt0-x234.google.com ([2607:f8b0:400d:c0d::234]:34673) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dKSSq-000694-Cq for emacs-orgmode@gnu.org; Mon, 12 Jun 2017 12:45:16 -0400 Received: by mail-qt0-x234.google.com with SMTP id c10so132832195qtd.1 for ; Mon, 12 Jun 2017 09:45:14 -0700 (PDT) In-Reply-To: <8737bap8px.fsf@gmail.com> List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: "Emacs-orgmode" To: "N. Raghavendra" , Org Mode --001a114340100ca7a40551c60bb2 Content-Type: text/plain; charset="UTF-8" Hi, You raise two important-seeming points about my patch: 1) a feature (display of language on hover) is removed by the patch 2) the patch also breaks XHTML validation That patch was submitted to add support for live code examples in exported HTML (using the klipse.js library). As it stands right now, both changes (addition of `data-editor-type` attribute and moving the language name class from `pre` to `code`) are necessary to make klipse work (cf. https://github.com/viebel/klipse). I'd rather not lose that functionality completely. Can you think of a way to solve both the problems without losing klipse funcitonality? If not, would you be satisfied with an improved docstring and maybe turning klipse off by default? On Thu, Jun 8, 2017 at 3:42 PM, N. Raghavendra wrote: > At 2017-06-08T21:24:31+02:00, Nicolas Goaziou wrote: > > > I'm Cc'ing Matt Price, who introduced klipse feature, for some > > insight. > > Thanks for the reply, and for the information. I'll wait for Matt > Price's response. > > > You posted the patch only two days ago. I hope you understand a "bump" > > may be a bit early at this point. > > Certainly. It was less a bump than an expression of concern that my > messages may have been lost in the general mileu of the mailing list. > > Cheers, > Raghu. > > -- > N. Raghavendra , http://www.retrotexts.net/ > Harish-Chandra Research Institute, http://www.hri.res.in/ > > --001a114340100ca7a40551c60bb2 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi,

You raise two importa= nt-seeming points about my patch:

1) a feature (display of lan= guage on hover) is removed by the patch
2) the patch also breaks X= HTML validation

That patch was submitted to add support for li= ve code examples in exported HTML (using the klipse.js=C2=A0 library).=C2= =A0 As it stands right now, both changes (addition of `data-editor-type` at= tribute and moving the language name class from `pre` to `code`) are necess= ary to make klipse work (cf. h= ttps://github.com/viebel/klipse).=C2=A0 I'd rather not lose that fu= nctionality completely. Can you think of a way to solve both the problems w= ithout losing klipse funcitonality? If not, would you be satisfied with an = improved docstring and maybe turning klipse off by default?


On Thu, Jun 8, 2017= at 3:42 PM, N. Raghavendra <nyraghu27132@gmail.com> wr= ote:
At 2017-06-08T21:24= :31+02:00, Nicolas Goaziou wrote:

> I'm Cc'ing Matt Price, who introduced klipse feature, for some=
> insight.

Thanks for the reply, and for the information.=C2=A0 I'll wait f= or Matt
Price's response.

> You posted the patch only two days ago. I hope you understand a "= bump"
> may be a bit early at this point.

Certainly.=C2=A0 It was less a bump than an expression of concern th= at my
messages may have been lost in the general mileu of the mailing list.

Cheers,
Raghu.

--
N. Raghavendra <raghu@hri.res.in= >, http://www.retrotexts.net/
Harish-Chandra Research Institute, http://www.hri.res.in/


--001a114340100ca7a40551c60bb2--