From: Puneeth Chaganti <punchagan@gmail.com>
To: Rasmus <rasmus@gmx.us>
Cc: emacs-orgmode <emacs-orgmode@gnu.org>
Subject: Re: [PATCH] org-id-goto doesn't work if buffer is narrowed.
Date: Sun, 25 Oct 2015 07:54:20 +0530 [thread overview]
Message-ID: <CALnw1fQc63_3yxiwwCywP4tSfHBdPBh9i9b2-u5g6ca=0E+U1w@mail.gmail.com> (raw)
In-Reply-To: <87pp04zc1r.fsf@gmx.us>
Hi Rasmus,
On Sat, Oct 24, 2015 at 5:57 PM, Rasmus <rasmus@gmx.us> wrote:
>
> However, you need to make sure that it only widens if ID is in the same
> buffer and outside of the narrow. In particular, when ID is in another
> file you shouldn’t widen. When it’s within the scope of the narrow it
> shouldn’t widen. This ALREADY seems to be the case.
I will fix the patch to widen only when the target location is not
within the narrow. But, I don't understand why we shouldn't be
widening if the target location is in a different buffer. Can you
explain?
> However, your patch doesn’t work for me in the following example, starting
> from emacs -q, adding /tmp/test.org (with the below content) to my agenda
> list and requiring org-id, org-narrow-to-subtree on foo, and then
> org-open-at-point on the link
I had patched `org-id-goto' and looks like clicking on links uses
`org-id-open'. I will resend a patch. I wonder if these two
functions can reuse common code.
--
Puneeth
next prev parent reply other threads:[~2015-10-25 2:24 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-23 15:11 [PATCH] org-id-goto doesn't work if buffer is narrowed Puneeth Chaganti
2015-10-23 15:27 ` Rasmus
2015-10-23 18:05 ` Puneeth Chaganti
2015-10-23 18:48 ` John Kitchin
2015-10-23 20:22 ` Rasmus
2015-10-24 5:29 ` Puneeth Chaganti
2015-10-24 11:33 ` John Kitchin
2015-10-24 11:49 ` Puneeth Chaganti
2015-10-24 11:57 ` Nicolas Goaziou
2015-10-24 12:47 ` Rasmus
2015-10-24 17:48 ` John Kitchin
2015-10-24 18:03 ` Rasmus
2015-10-25 11:11 ` John Kitchin
2015-10-24 12:27 ` Rasmus
2015-10-25 2:24 ` Puneeth Chaganti [this message]
2015-10-25 3:12 ` Puneeth Chaganti
2015-10-25 8:38 ` Nicolas Goaziou
2015-10-25 9:10 ` Puneeth Chaganti
2015-10-25 9:42 ` Nicolas Goaziou
2015-10-25 9:57 ` Puneeth Chaganti
2015-10-25 11:19 ` Rasmus
2015-10-26 14:14 ` Puneeth Chaganti
2015-10-23 19:59 ` Matt Lundin
2015-10-23 20:18 ` Rasmus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CALnw1fQc63_3yxiwwCywP4tSfHBdPBh9i9b2-u5g6ca=0E+U1w@mail.gmail.com' \
--to=punchagan@gmail.com \
--cc=emacs-orgmode@gnu.org \
--cc=rasmus@gmx.us \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).