emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed

From: Puneeth Chaganti <punchagan@gmail.com>
To: John Kitchin <jkitchin@andrew.cmu.edu>
Cc: emacs-orgmode <emacs-orgmode@gnu.org>, Rasmus <rasmus@gmx.us>
Subject: Re: [PATCH] org-id-goto doesn't work if buffer is narrowed.
Date: Sat, 24 Oct 2015 17:19:01 +0530	[thread overview]
Message-ID: <CALnw1fS5c8gu9vkJb57Vo8L78JCLuynfAQgJk0NNSoM57a0q5w@mail.gmail.com> (raw)
In-Reply-To: <CAJ51ETry9SEzi3C+nw3LWf=1ejUV=rh+k+eZwMeBwqjfSXaEnQ@mail.gmail.com>

Hi John,

On Sat, Oct 24, 2015 at 5:03 PM, John Kitchin <jkitchin@andrew.cmu.edu> wrote:
>
> Maybe I am missing something here. I would expect org-id-goto to actually
> get to the id entry when it is used independent of narrowing. When used in a
> program, I would expect this behavior to be wrapped in save-restriction type
> macros, so it wouldn't change your restriction. But when used interactively,
> e.g. when I click on a link, I expect the point to end up on the id entry,
> with the buffer open in front of me, even if that means widening. Is there
> some other expectation that makes sense? I feel like it is up to me to
> decide if breaking the restriction is worth visiting the link, and only by
> clicking on the link or running an interactive command makes that happen.

Thanks for spelling it out so clearly. I wasn't thinking clearly,
before.  I completely agree with you that the user should be the one
deciding if its "worth breaking the restriction".  Any calling code
would be saving restriction, if that is the intent.

+1 on simply widening the buffer, with an optional warning/error that
can be turned on or off with a variable.

-- 
Puneeth

next prev parent reply	other threads:[~2015-10-24 11:49 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-23 15:11 [PATCH] org-id-goto doesn't work if buffer is narrowed Puneeth Chaganti
2015-10-23 15:27 ` Rasmus
2015-10-23 18:05   ` Puneeth Chaganti
2015-10-23 18:48     ` John Kitchin
2015-10-23 20:22     ` Rasmus
2015-10-24  5:29       ` Puneeth Chaganti
2015-10-24 11:33         ` John Kitchin
2015-10-24 11:49           ` Puneeth Chaganti [this message]
2015-10-24 11:57           ` Nicolas Goaziou
2015-10-24 12:47           ` Rasmus
2015-10-24 17:48             ` John Kitchin
2015-10-24 18:03               ` Rasmus
2015-10-25 11:11                 ` John Kitchin
2015-10-24 12:27         ` Rasmus
2015-10-25  2:24           ` Puneeth Chaganti
2015-10-25  3:12             ` Puneeth Chaganti
2015-10-25  8:38               ` Nicolas Goaziou
2015-10-25  9:10                 ` Puneeth Chaganti
2015-10-25  9:42                   ` Nicolas Goaziou
2015-10-25  9:57                     ` Puneeth Chaganti
2015-10-25 11:19             ` Rasmus
2015-10-26 14:14               ` Puneeth Chaganti
2015-10-23 19:59   ` Matt Lundin
2015-10-23 20:18     ` Rasmus

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CALnw1fS5c8gu9vkJb57Vo8L78JCLuynfAQgJk0NNSoM57a0q5w@mail.gmail.com \
    --to=punchagan@gmail.com \
    --cc=emacs-orgmode@gnu.org \
    --cc=jkitchin@andrew.cmu.edu \
    --cc=rasmus@gmx.us \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).