[bug] Org-capture bug due to recent dired-buffers related feature

[bug] Org-capture bug due to recent dired-buffers related feature

[Puneeth Chaganti]

Hi Nicolas,

The recent commit that adds a dired-buffer related feature, breaks
org-capture when dired-mode has not been loaded.  The dired-buffers
variable becomes available only when dired-mode has been loaded
atleast once.

Thanks,
Puneeth

Git bisect output, just for reference.

819fbec64160c3c33884b116734c01f56be7606b is the first bad commit
commit 819fbec64160c3c33884b116734c01f56be7606b
Author: Nicolas Goaziou <n.goaziou@gmail.com>
Date:   Mon Jul 18 17:42:01 2011 +0200

    org-capture: %F is directory when capture starts in a dired buffer

    * lisp/org-capture.el (org-capture): if no file is associated to
      current buffer, check dired buffer and try to retreive a possibly
      directory associated.

:040000 040000 2ae961f6f609dbc28aa8e727df5a04465991645d
02aef5b5063d0642d4b260b7567a1e135bf73a14 M	lisp

Re: [bug] Org-capture bug due to recent dired-buffers related feature

[Nicolas Goaziou]

Hello,

Puneeth Chaganti <punchagan@gmail.com> writes:

> The recent commit that adds a dired-buffer related feature, breaks
> org-capture when dired-mode has not been loaded.  The dired-buffers
> variable becomes available only when dired-mode has been loaded
> atleast once.

True. This should be fixed now. Let me know if this isn't the case.

Thank you.

Regards,

-- 
Nicolas Goaziou

Re: [bug] Org-capture bug due to recent dired-buffers related feature

[Bastien]

Hi Puneeth,

Puneeth Chaganti <punchagan@gmail.com> writes:

> The recent commit that adds a dired-buffer related feature, breaks
> org-capture when dired-mode has not been loaded.  The dired-buffers
> variable becomes available only when dired-mode has been loaded
> atleast once.

Fixed by requiring dired with (require 'dired) in org-capture.el.

Thanks,

-- 
 Bastien

Re: [bug] Org-capture bug due to recent dired-buffers related feature

[Bastien]

Hi Nicolas,

Nicolas Goaziou <n.goaziou@gmail.com> writes:

> True. This should be fixed now. Let me know if this isn't the case.

Your fix is better -- I reverted mine.

Thanks!

-- 
 Bastien

Re: [bug] Org-capture bug due to recent dired-buffers related feature

[Puneeth Chaganti]

Nicolas,

On 7/19/11, Nicolas Goaziou <n.goaziou@gmail.com> wrote:
> Hello,
>
> Puneeth Chaganti <punchagan@gmail.com> writes:
>
>> The recent commit that adds a dired-buffer related feature, breaks
>> org-capture when dired-mode has not been loaded.  The dired-buffers
>> variable becomes available only when dired-mode has been loaded
>> atleast once.
>
> True. This should be fixed now. Let me know if this isn't the case.

Fixed, thanks!

--
Puneeth