* [bug] Org-capture bug due to recent dired-buffers related feature
@ 2011-07-19 14:08 Puneeth Chaganti
2011-07-19 15:53 ` Nicolas Goaziou
2011-07-19 16:32 ` Bastien
0 siblings, 2 replies; 5+ messages in thread
From: Puneeth Chaganti @ 2011-07-19 14:08 UTC (permalink / raw)
To: emacs-orgmode, Nicolas Goaziou
Hi Nicolas,
The recent commit that adds a dired-buffer related feature, breaks
org-capture when dired-mode has not been loaded. The dired-buffers
variable becomes available only when dired-mode has been loaded
atleast once.
Thanks,
Puneeth
Git bisect output, just for reference.
819fbec64160c3c33884b116734c01f56be7606b is the first bad commit
commit 819fbec64160c3c33884b116734c01f56be7606b
Author: Nicolas Goaziou <n.goaziou@gmail.com>
Date: Mon Jul 18 17:42:01 2011 +0200
org-capture: %F is directory when capture starts in a dired buffer
* lisp/org-capture.el (org-capture): if no file is associated to
current buffer, check dired buffer and try to retreive a possibly
directory associated.
:040000 040000 2ae961f6f609dbc28aa8e727df5a04465991645d
02aef5b5063d0642d4b260b7567a1e135bf73a14 M lisp
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [bug] Org-capture bug due to recent dired-buffers related feature
2011-07-19 14:08 [bug] Org-capture bug due to recent dired-buffers related feature Puneeth Chaganti
@ 2011-07-19 15:53 ` Nicolas Goaziou
2011-07-19 16:41 ` Bastien
2011-07-20 7:02 ` Puneeth Chaganti
2011-07-19 16:32 ` Bastien
1 sibling, 2 replies; 5+ messages in thread
From: Nicolas Goaziou @ 2011-07-19 15:53 UTC (permalink / raw)
To: Puneeth Chaganti; +Cc: emacs-orgmode
Hello,
Puneeth Chaganti <punchagan@gmail.com> writes:
> The recent commit that adds a dired-buffer related feature, breaks
> org-capture when dired-mode has not been loaded. The dired-buffers
> variable becomes available only when dired-mode has been loaded
> atleast once.
True. This should be fixed now. Let me know if this isn't the case.
Thank you.
Regards,
--
Nicolas Goaziou
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [bug] Org-capture bug due to recent dired-buffers related feature
2011-07-19 14:08 [bug] Org-capture bug due to recent dired-buffers related feature Puneeth Chaganti
2011-07-19 15:53 ` Nicolas Goaziou
@ 2011-07-19 16:32 ` Bastien
1 sibling, 0 replies; 5+ messages in thread
From: Bastien @ 2011-07-19 16:32 UTC (permalink / raw)
To: Puneeth Chaganti; +Cc: Nicolas Goaziou, emacs-orgmode
Hi Puneeth,
Puneeth Chaganti <punchagan@gmail.com> writes:
> The recent commit that adds a dired-buffer related feature, breaks
> org-capture when dired-mode has not been loaded. The dired-buffers
> variable becomes available only when dired-mode has been loaded
> atleast once.
Fixed by requiring dired with (require 'dired) in org-capture.el.
Thanks,
--
Bastien
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [bug] Org-capture bug due to recent dired-buffers related feature
2011-07-19 15:53 ` Nicolas Goaziou
@ 2011-07-19 16:41 ` Bastien
2011-07-20 7:02 ` Puneeth Chaganti
1 sibling, 0 replies; 5+ messages in thread
From: Bastien @ 2011-07-19 16:41 UTC (permalink / raw)
To: Nicolas Goaziou; +Cc: emacs-orgmode
Hi Nicolas,
Nicolas Goaziou <n.goaziou@gmail.com> writes:
> True. This should be fixed now. Let me know if this isn't the case.
Your fix is better -- I reverted mine.
Thanks!
--
Bastien
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [bug] Org-capture bug due to recent dired-buffers related feature
2011-07-19 15:53 ` Nicolas Goaziou
2011-07-19 16:41 ` Bastien
@ 2011-07-20 7:02 ` Puneeth Chaganti
1 sibling, 0 replies; 5+ messages in thread
From: Puneeth Chaganti @ 2011-07-20 7:02 UTC (permalink / raw)
To: Nicolas Goaziou; +Cc: emacs-orgmode
Nicolas,
On 7/19/11, Nicolas Goaziou <n.goaziou@gmail.com> wrote:
> Hello,
>
> Puneeth Chaganti <punchagan@gmail.com> writes:
>
>> The recent commit that adds a dired-buffer related feature, breaks
>> org-capture when dired-mode has not been loaded. The dired-buffers
>> variable becomes available only when dired-mode has been loaded
>> atleast once.
>
> True. This should be fixed now. Let me know if this isn't the case.
Fixed, thanks!
--
Puneeth
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2011-07-20 13:25 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-07-19 14:08 [bug] Org-capture bug due to recent dired-buffers related feature Puneeth Chaganti
2011-07-19 15:53 ` Nicolas Goaziou
2011-07-19 16:41 ` Bastien
2011-07-20 7:02 ` Puneeth Chaganti
2011-07-19 16:32 ` Bastien
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).