Re: [PATCH] custom port for postgresql

[Jakob Lombacher <Jakob@lombacher.net>]

[-- Attachment #1.1: Type: text/plain, Size: 751 bytes --]

Hi Nicolas,

sure, here you go.

All the best

Jakob

2016-09-17 10:39 GMT+02:00 Nicolas Goaziou <mail@nicolasgoaziou.fr>:

> Hello,
>
> Jakob Lombacher <Jakob@lombacher.net> writes:
>
> > I changed the dbport as optional argument and added the dbpassword option
> > as well.
>
> I applied your patch with the modifications below:
>
> - I added a proper commit message
>
> - I added TINYCHANGE cookie
>
> - I reordered dbport argument as in your initial patch. Although the
>   recommendation of making it optional makes sense, it breaks
>   consistency with other "dbstring" functions, and this is an internal
>   function anyway.
>
> Could you provide an entry for ORG-NEWS file?
>
> Thank you for the patch.
>
> Regards,
>
> --
> Nicolas Goaziou
>

[-- Attachment #1.2: Type: text/html, Size: 1324 bytes --]

[-- Attachment #2: 0001-ORG-NEWS-support-of-header-argument-for-postgresql.patch --]
[-- Type: text/x-patch, Size: 1007 bytes --]

From dd964b7af9ea082a5d8d71630565899dabf7a116 Mon Sep 17 00:00:00 2001
From: Jakob Lombacher <Jakob@Lombacher.net>
Date: Thu, 22 Sep 2016 15:59:35 +0200
Subject: [PATCH] ORG-NEWS support of header argument for postgresql

---
 etc/ORG-NEWS | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/etc/ORG-NEWS b/etc/ORG-NEWS
index eda018f..de99f7b 100644
--- a/etc/ORG-NEWS
+++ b/etc/ORG-NEWS
@@ -317,6 +317,11 @@ Alice <-- Bob: another authentication Response
 Please note that *pdf* *does not work out of the box* and needss
 additional setup in addition to plantuml. See
 [[http://plantuml.com/pdf.html]] for details and setup information.
+**** Improved support of header arguments for postgresql 
+     The postgresql engine in a sql code block supports now *:dbport*
+     and *:dbpassword* as header arguments.
+     
+     
 *** Rewrite of radio lists
 Radio lists, i.e, Org plain lists in foreign buffers, have been
 rewritten to be on par with Radio tables.  You can use a large set of
-- 
2.8.1