[BUG] org-get-buffer-tags no longer strips text properties

[BUG] org-get-buffer-tags no longer strips text properties

[Anders Johansson]

[-- Attachment #1: Type: text/plain, Size: 641 bytes --]

Hi,
Commit 819409 introduced a change where the text-properties of tags
collected from a buffer are no longer stripped, which means tags may be
fontified in unwanted ways in completing-read (this became especially ugly
using org-modern and code for right aligning tags with display properties).

Something like this would fix it:
@@ -11974,7 +11974,7 @@ (defun org-get-buffer-tags ()
         (org-element-cache-map
          (lambda (el)
            (dolist (tag (org-element-property :tags el))
-             (puthash (list tag) t hashed))))
+             (puthash (list (substring-no-properties tag)) t hashed))))

Best,
Anders Johansson

[-- Attachment #2: Type: text/html, Size: 815 bytes --]

Re: [BUG] org-get-buffer-tags no longer strips text properties

[Ihor Radchenko]

Anders Johansson <mejlaandersj@gmail.com> writes:

> Hi,
> Commit 819409 introduced a change where the text-properties of tags
> collected from a buffer are no longer stripped, which means tags may be
> fontified in unwanted ways in completing-read (this became especially ugly
> using org-modern and code for right aligning tags with display properties).
>
> Something like this would fix it:
> @@ -11974,7 +11974,7 @@ (defun org-get-buffer-tags ()
>          (org-element-cache-map
>           (lambda (el)
>             (dolist (tag (org-element-property :tags el))
> -             (puthash (list tag) t hashed))))
> +             (puthash (list (substring-no-properties tag)) t hashed))))

Thanks for reporting!
Fixed on main via 6acc58c9c.
https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=6acc58c9c6bcfd45dcc5964cac7e3df8347121cc

-- 
Ihor Radchenko,
Org mode contributor,
Learn more about Org mode at https://orgmode.org/.
Support Org development at https://liberapay.com/org-mode,
or support my work at https://liberapay.com/yantar92