emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Ihor Radchenko <yantar92@gmail.com>
To: Anders Johansson <mejlaandersj@gmail.com>
Cc: org-mode-email <emacs-orgmode@gnu.org>
Subject: Re: [BUG] org-get-buffer-tags no longer strips text properties
Date: Thu, 11 Aug 2022 19:40:52 +0800	[thread overview]
Message-ID: <875yiz9fej.fsf@localhost> (raw)
In-Reply-To: <CAKJdtO_0aUmiKFjS34hoD525vMFkUJuVCCzGrFfR_Lt2_Vm58g@mail.gmail.com>

Anders Johansson <mejlaandersj@gmail.com> writes:

> Hi,
> Commit 819409 introduced a change where the text-properties of tags
> collected from a buffer are no longer stripped, which means tags may be
> fontified in unwanted ways in completing-read (this became especially ugly
> using org-modern and code for right aligning tags with display properties).
> Something like this would fix it:
> @@ -11974,7 +11974,7 @@ (defun org-get-buffer-tags ()
>          (org-element-cache-map
>           (lambda (el)
>             (dolist (tag (org-element-property :tags el))
> -             (puthash (list tag) t hashed))))
> +             (puthash (list (substring-no-properties tag)) t hashed))))

Thanks for reporting!
Fixed on main via 6acc58c9c.

Ihor Radchenko,
Org mode contributor,
Learn more about Org mode at https://orgmode.org/.
Support Org development at https://liberapay.com/org-mode,
or support my work at https://liberapay.com/yantar92

      reply	other threads:[~2022-08-11 11:42 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-11  9:31 [BUG] org-get-buffer-tags no longer strips text properties Anders Johansson
2022-08-11 11:40 ` Ihor Radchenko [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=875yiz9fej.fsf@localhost \
    --to=yantar92@gmail.com \
    --cc=emacs-orgmode@gnu.org \
    --cc=mejlaandersj@gmail.com \


* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox


This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).