Re: bug#23745: 25.0.94; Org: (pop-to-mark-command) doesn't work when using (org-open-at-point) to visit a same-file link

Re: bug#23745: 25.0.94; Org: (pop-to-mark-command) doesn't work when using (org-open-at-point) to visit a same-file link

[Rasmus]

The following message is a courtesy copy of an article
that has been posted to gmane.emacs.bugs as well.

Hi Dima,

Thanks for the report.

Dima Kogan <dima@secretsauce.net> writes:

> =====================
> * aaaa
> bbbbb
>
> * cccc
> [[aaaa]]
> =====================
>
> With the point at the [[aaaa]] link, I can visit the aaaa heading with
> C-c C-o (org-open-at-point), and I can go back to where I was with the
> org-specific C-c & (org-mark-ring-goto). But I should also be able to go
> back with C-u C-SPC (effectively pop-to-mark-command), since that works
> for inside-the-same-buffer jumps in all other emacs context, including
> non-org ones. I suspect all we would need to do is to
> (push-mark-command) before we jump in (org-open-at-point). Is this
> simply forgotten, or was it omitted on purpose? If the former, I'll post
> a patch.

I think you are right; your description of behavior would be consistent.
Note that once I click C-c & at "* aaaa" and thus return to the link
"[[aaaa]]" I can pop the mark to go back to "* aaaa" but the reverse is
not possible.

A fix for this would be appreciated.

Thanks,
Rasmus

-- 
Send from my Emacs

bug#23745: 25.0.94; Org: (pop-to-mark-command) doesn't work when using (org-open-at-point) to visit a same-file link

[Nicolas Goaziou]

Hello,

Dima Kogan <dima@secretsauce.net> writes:

> Hi. Consider this org-mode file:
>
> =====================
> * aaaa
> bbbbb
>
> * cccc
> [[aaaa]]
> =====================
>
> With the point at the [[aaaa]] link, I can visit the aaaa heading with
> C-c C-o (org-open-at-point), and I can go back to where I was with the
> org-specific C-c & (org-mark-ring-goto). But I should also be able to go
> back with C-u C-SPC (effectively pop-to-mark-command), since that works
> for inside-the-same-buffer jumps in all other emacs context, including
> non-org ones. I suspect all we would need to do is to
> (push-mark-command) before we jump in (org-open-at-point). Is this
> simply forgotten, or was it omitted on purpose? If the former, I'll post
> a patch.

Fixed.

Now `org-mark-ring-push' also calls `push-mark'. Ultimately, I think the
latter should replace former, although navigation with Org dedicated
mark ring is still slightly easier (e.g., no distinction between global
and local rings).

Thank you.

Regards,

-- 
Nicolas Goaziou                                                0x80A93738

bug#23745: bug#23745: 25.0.94; Org: (pop-to-mark-command) doesn't work when using (org-open-at-point) to visit a same-file link

[Samuel Wales]

quite useful to have this for reference in the org mailing list, as we
are discussing it.

bug#23745: bug#23745: 25.0.94; Org: (pop-to-mark-command) doesn't work when using (org-open-at-point) to visit a same-file link

[Samuel Wales]

quite useful to have this for reference in the org mailing list, as we
are discussing it.