From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nicolas Goaziou Subject: bug#23745: 25.0.94; Org: (pop-to-mark-command) doesn't work when using (org-open-at-point) to visit a same-file link Date: Tue, 27 Feb 2018 01:10:48 +0100 Message-ID: <87tvu3xpfb.fsf@nicolasgoaziou.fr> References: <87twh01tfu.fsf@secretsauce.net> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:51030) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eqSrJ-0002En-E8 for emacs-orgmode@gnu.org; Mon, 26 Feb 2018 19:11:06 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eqSrG-0000uH-8d for emacs-orgmode@gnu.org; Mon, 26 Feb 2018 19:11:05 -0500 Sender: "Debbugs-submit" Resent-To: bug-gnu-emacs@gnu.org, emacs-orgmode@gnu.org Resent-Message-ID: In-Reply-To: <87twh01tfu.fsf@secretsauce.net> (Dima Kogan's message of "Fri, 10 Jun 2016 17:05:09 -0700") List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: "Emacs-orgmode" To: Dima Kogan Cc: 23745-done@debbugs.gnu.org Hello, Dima Kogan writes: > Hi. Consider this org-mode file: > > ===================== > * aaaa > bbbbb > > * cccc > [[aaaa]] > ===================== > > With the point at the [[aaaa]] link, I can visit the aaaa heading with > C-c C-o (org-open-at-point), and I can go back to where I was with the > org-specific C-c & (org-mark-ring-goto). But I should also be able to go > back with C-u C-SPC (effectively pop-to-mark-command), since that works > for inside-the-same-buffer jumps in all other emacs context, including > non-org ones. I suspect all we would need to do is to > (push-mark-command) before we jump in (org-open-at-point). Is this > simply forgotten, or was it omitted on purpose? If the former, I'll post > a patch. Fixed. Now `org-mark-ring-push' also calls `push-mark'. Ultimately, I think the latter should replace former, although navigation with Org dedicated mark ring is still slightly easier (e.g., no distinction between global and local rings). Thank you. Regards, -- Nicolas Goaziou 0x80A93738