refile too slow

refile too slow

[Samuel Wales]

recent maint, but been a problem for a few mo.

refile hits a wall.  depends on number of headers.

i think delete-dups is suspicious here.  is its only purpose to
eliminate the existing
header?

   - org-refile                                                47808  91%
     - org-refile-get-location                                  47780  91%
      - org-refile-get-targets                                  44120  84%
         delete-dups                                            36613  70%
         match-string-no-properties                               548   1%

-- 
The Kafka Pandemic: <http://thekafkapandemic.blogspot.com>

The disease DOES progress. MANY people have died from it. And ANYBODY
can get it at any time.

"You’ve really gotta quit this and get moving, because this is murder
by neglect." ---
<http://www.meaction.net/2017/02/03/pwme-people-with-me-are-being-murdered-by-neglect>.



-- 
The Kafka Pandemic: <http://thekafkapandemic.blogspot.com>

The disease DOES progress. MANY people have died from it. And ANYBODY
can get it at any time.

"You’ve really gotta quit this and get moving, because this is murder
by neglect." ---
<http://www.meaction.net/2017/02/03/pwme-people-with-me-are-being-murdered-by-neglect>.

Re: refile too slow

[Nicolas Goaziou]

Hello,

Samuel Wales <samologist@gmail.com> writes:

> recent maint, but been a problem for a few mo.
>
> refile hits a wall.  depends on number of headers.
>
> i think delete-dups is suspicious here.  is its only purpose to
> eliminate the existing
> header?

Why is delete-dups suspicious? Have you got a very large number of
refile locations? If so, would it make sense to refine your target
definitions?

Its purpose, as its name suggests, is to remove duplicate refile
locations you could get.

Regards,

-- 
Nicolas Goaziou

Re: refile too slow

[Samuel Wales]

On 10/5/17, Nicolas Goaziou <mail@nicolasgoaziou.fr> wrote:
>> i think delete-dups is suspicious here.  is its only purpose to
>
> Why is delete-dups suspicious? Have you got a very large number of
> refile locations? If so, would it make sense to refine your target
> definitions?

already do that.  my fallback "get most things down to a reasonable
level" refile and refile goto were ok until recently.  then they
became untenably slow.  i can't refine it more without missing stuff
that i need.

> Its purpose, as its name suggests, is to remove duplicate refile
> locations you could get.

so only useful if i set the variable with duplicate stuff?

===

delete-dups seems suspicious but what do i know.  i wonder if
cl-delete-duplicates is more efficient.

(defun delete-dups (list)
  "Destructively remove `equal' duplicates from LIST.
Store the result in LIST and return it.  LIST must be a proper list.
Of several `equal' occurrences of an element in LIST, the first
one is kept."
  (let ((tail list))
    (while tail
      (setcdr tail (delete (car tail) (cdr tail)))
      (setq tail (cdr tail))))
  list)

Re: refile too slow

[Samuel Wales]

On 10/5/17, Samuel Wales <samologist@gmail.com> wrote:
> delete-dups seems suspicious but what do i know.  i wonder if
> cl-delete-duplicates is more efficient.

perhaps it has been made more efficient in new emacs versions than 24?

>
> (defun delete-dups (list)
>   "Destructively remove `equal' duplicates from LIST.
> Store the result in LIST and return it.  LIST must be a proper list.
> Of several `equal' occurrences of an element in LIST, the first
> one is kept."
>   (let ((tail list))
>     (while tail
>       (setcdr tail (delete (car tail) (cdr tail)))
>       (setq tail (cdr tail))))
>   list)
>


-- 
The Kafka Pandemic: <http://thekafkapandemic.blogspot.com>

The disease DOES progress. MANY people have died from it. And ANYBODY
can get it at any time.

"You’ve really gotta quit this and get moving, because this is murder
by neglect." ---
<http://www.meaction.net/2017/02/03/pwme-people-with-me-are-being-murdered-by-neglect>.