From: Samim Pezeshki <p.samim@gmail.com>
To: emacs-orgmode@gnu.org
Subject: [PATCH] org-agenda: Skip formatting if format string is ""
Date: Sat, 8 May 2021 20:25:19 +0430 [thread overview]
Message-ID: <CAJAdVc3tojPXDf7dm=aXRaP-yTDwsEvebS0Wx0nuxQLc+yuUbQ@mail.gmail.com> (raw)
[-- Attachment #1.1: Type: text/plain, Size: 248 bytes --]
Hi!
This is my first patch.
The patch skips formatting TODO item in org-agenda when the format string
is "".
When the format string was "" the extra space would still be inserted which
was not needed when there is no TODO keyword.
Thanks,
Samim
[-- Attachment #1.2: Type: text/html, Size: 1214 bytes --]
[-- Attachment #2: 0001-org-agenda-Skip-formatting-if-format-string-is.patch --]
[-- Type: text/x-patch, Size: 1331 bytes --]
From dc3ba301219622bc7d324901a5f277024f8b55cc Mon Sep 17 00:00:00 2001
From: Samim Pezeshki <psamim@gmail.com>
Date: Sat, 8 May 2021 20:09:16 +0430
Subject: [PATCH] org-agenda: Skip formatting if format string is ""
When the format string was "" the extra space would still be inserted
which was not needed when there is no TODO keyword.
---
lisp/org-agenda.el | 13 +++++++------
1 file changed, 7 insertions(+), 6 deletions(-)
diff --git a/lisp/org-agenda.el b/lisp/org-agenda.el
index 85e201086..32ed19afc 100644
--- a/lisp/org-agenda.el
+++ b/lisp/org-agenda.el
@@ -7147,12 +7147,13 @@ The optional argument TYPE tells the agenda type."
(setq x
(concat
(substring x 0 (match-end 1))
- (format org-agenda-todo-keyword-format
- (match-string 2 x))
- ;; Remove `display' property as the icon could leak
- ;; on the white space.
- (org-add-props " " (org-plist-delete (text-properties-at 0 x)
- 'display))
+ (when (not (eq org-agenda-todo-keyword-format ""))
+ (format org-agenda-todo-keyword-format
+ (match-string 2 x))
+ ;; Remove `display' property as the icon could leak
+ ;; on the white space.
+ (org-add-props " " (org-plist-delete (text-properties-at 0 x)
+ 'display)))
(substring x (match-end 3)))))))
x)))
--
2.31.1
next reply other threads:[~2021-05-08 16:21 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-08 15:55 Samim Pezeshki [this message]
2021-05-15 8:12 ` [PATCH] org-agenda: Skip formatting if format string is "" Bastien
-- strict thread matches above, loose matches on Subject: below --
2022-02-05 17:02 Samim Pezeshki
2022-02-06 9:28 ` Ihor Radchenko
2022-02-09 19:14 ` Samim Pezeshki
2022-03-15 18:35 ` Samim Pezeshki
2022-03-21 7:34 ` Ihor Radchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJAdVc3tojPXDf7dm=aXRaP-yTDwsEvebS0Wx0nuxQLc+yuUbQ@mail.gmail.com' \
--to=p.samim@gmail.com \
--cc=emacs-orgmode@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).