From: Ihor Radchenko <yantar92@gmail.com> To: Samim Pezeshki <p.samim@gmail.com> Cc: emacs-orgmode@gnu.org, Nicolas Goaziou <mail@nicolasgoaziou.fr> Subject: Re: [PATCH] org-agenda: Skip formatting if format string is "" Date: Sun, 06 Feb 2022 17:28:30 +0800 [thread overview] Message-ID: <87v8xsuywx.fsf@localhost> (raw) In-Reply-To: <CAJAdVc0GpUnv=+rpz4f8FWMXsonpC+H2j8uXZHNKUHBfPRst_w@mail.gmail.com> Samim Pezeshki <p.samim@gmail.com> writes: > This commit prevents having extra spaces when the TODO format string is an > empty string (""). It was not working properly, with this patch now it > works correctly. Thanks for the patch! > (concat > (substring x 0 (match-end 1)) > ... > + (unless (string= org-agenda-todo-keyword-format "") > + (format org-agenda-todo-keyword-format > + (match-string 2 x)) > + ;; Remove `display' property as the icon could leak > + ;; on the white space. > + (org-add-props " " (org-plist-delete (text-properties-at 0 x) > + 'display))) > (substring x (match-end 3))))))) > x))) Your patch will unconditionally hide todo keywords in agenda even when org-agenda-todo-keyword-format is not empty. This will happen because (unless ...) form will only return the last " ", but never the keyword. You should better wrap the (org-add-props ...) with another unless condition. Best, Ihor
next prev parent reply other threads:[~2022-02-06 9:28 UTC|newest] Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-02-05 17:02 Samim Pezeshki 2022-02-06 9:28 ` Ihor Radchenko [this message] 2022-02-09 19:14 ` Samim Pezeshki 2022-03-15 18:35 ` Samim Pezeshki 2022-03-21 7:34 ` Ihor Radchenko -- strict thread matches above, loose matches on Subject: below -- 2021-05-08 15:55 Samim Pezeshki 2021-05-15 8:12 ` Bastien
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style List information: https://www.orgmode.org/ * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=87v8xsuywx.fsf@localhost \ --to=yantar92@gmail.com \ --cc=emacs-orgmode@gnu.org \ --cc=mail@nicolasgoaziou.fr \ --cc=p.samim@gmail.com \ --subject='Re: [PATCH] org-agenda: Skip formatting if format string is ""' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Code repositories for project(s) associated with this inbox: https://git.savannah.gnu.org/cgit/emacs/org-mode.git This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).