Regression in org-table-recalculate-buffer-tables and #+startup: shrink [devel branch]

Regression in org-table-recalculate-buffer-tables and #+startup: shrink [devel branch]

[Kaushal Modi]

[-- Attachment #1: Type: text/plain, Size: 1171 bytes --]

Hello,

Lately (past week), I have noticed a failure for all functions to run from
my org-mode-hook, because I got an error like:

    File mode specification error: (user-error Not at a table)

This error happens if:

1. I call M-x org-table-recalculate-buffer-tables (I have that function in
my org-mode-hook).
2. The Org buffer has #+startup: shrink, and
3. An Org table with column width cookies has #+caption.

Here's a minimal reproducible example:

=====
#+title: User-error when trying to recalculate tables in buffer with shrink
enabled
#+startup: shrink

#+caption: Foo
| <25> |
| Foo  |
=====

1. Save above to an Org file, close and reopen that file so that #+startup
gets evaluated.
2. M-x org-table-recalculate-buffer-tables and you will get the
"user-error: Not at a table" error.

Interestingly, this error does not show up if simply that #+caption line is
removed.

I believe that this commit caused this regression:
https://code.orgmode.org/bzg/org-mode/commit/222408d70a3674f06ddd6b77e4e1126c602e7361
.

Org mode version 9.2.3 (release_9.2.3-336-g09a1a2 @
/home/kmodi/usr_local/apps/6/emacs/master/share/emacs/site-lisp/org/)

Thanks!

--
Kaushal Modi

[-- Attachment #2: Type: text/html, Size: 2031 bytes --]

Re: Regression in org-table-recalculate-buffer-tables and #+startup: shrink [devel branch]

[Nicolas Goaziou]

Hello,

Kaushal Modi <kaushal.modi@gmail.com> writes:

> Lately (past week), I have noticed a failure for all functions to run from
> my org-mode-hook, because I got an error like:
>
>     File mode specification error: (user-error Not at a table)
>
> This error happens if:
>
> 1. I call M-x org-table-recalculate-buffer-tables (I have that function in
> my org-mode-hook).
> 2. The Org buffer has #+startup: shrink, and
> 3. An Org table with column width cookies has #+caption.
>
> Here's a minimal reproducible example:
>
> =====
>
> #+title: User-error when trying to recalculate tables in buffer with shrink
> enabled
>
> #+startup: shrink
>
> #+caption: Foo
> | <25> |
>
> | Foo  |
> =====
>
> 1. Save above to an Org file, close and reopen that file so that #+startup
> gets evaluated.
> 2. M-x org-table-recalculate-buffer-tables and you will get the
> "user-error: Not at a table" error.

Fixed. Thank you.

Regards,

-- 
Nicolas Goaziou

Re: Regression in org-table-recalculate-buffer-tables and #+startup: shrink [devel branch]

[Kaushal Modi]

[-- Attachment #1: Type: text/plain, Size: 151 bytes --]

Hello Nicolas,

On Tue, Apr 23, 2019 at 4:37 AM Nicolas Goaziou <mail@nicolasgoaziou.fr>
wrote:

>
> Fixed. Thank you.
>

Thank you for the quick fix!

[-- Attachment #2: Type: text/html, Size: 524 bytes --]