emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
* batch failure of first org-num test
@ 2019-01-07 19:18 Kyle Meyer
  2019-01-07 19:56 ` Kyle Meyer
  0 siblings, 1 reply; 3+ messages in thread
From: Kyle Meyer @ 2019-01-07 19:18 UTC (permalink / raw)
  To: emacs-orgmode

Hello,

When I run the tests on master in batch (specifically ‘make test’),
test-org-num/format-function fails (backtrace at end of message).  That
test doesn't fail if I run it interactively.

Looking at test-org-num.el, I see that the first test,
test-org-num/face, is commented with the explanation “FIXME: this test
fails in batch mode”.  So it seems that commenting out that test just
pushes the failure down the line.  And indeed if I comment out
test-org-num/format-function, the next test fails.

I don’t have an understanding of the underlying issue, but if I add
‘(require 'org-num)’ to test-org-num.el, all tests pass for me with
‘make test’.

--8<---------------cut here---------------start------------->8---
Test test-org-num/format-function backtrace:
  signal(ert-test-failed (((should (equal '("foo" "foo") (org-test-wit
  ert-fail(((should (equal '("foo" "foo") (org-test-with-temp-text "* 
  (if (unwind-protect (setq value-8786 (apply fn-8784 args-8785)) (set
  (let (form-description-8788) (if (unwind-protect (setq value-8786 (a
  (let ((value-8786 'ert-form-evaluation-aborted-8787)) (let (form-des
  (let* ((fn-8784 (function equal)) (args-8785 (condition-case err (le
  (closure (t) nil (let* ((fn-8784 (function equal)) (args-8785 (condi
  ert--run-test-internal(#s(ert--test-execution-info :test #s(ert-test
  ert-run-test(#s(ert-test :name test-org-num/format-function :documen
  ert-run-or-rerun-test(#s(ert--stats :selector "\\(org\\|ob\\)" :test
  ert-run-tests("\\(org\\|ob\\)" #f(compiled-function (event-type &res
  ert-run-tests-batch("\\(org\\|ob\\)")
  ert-run-tests-batch-and-exit("\\(org\\|ob\\)")
  (let ((org-id-track-globally t) (org-test-selector (if org-test-sele
  org-test-run-batch-tests("\\(org\\|ob\\)")
  eval((org-test-run-batch-tests org-test-select-re))
  command-line-1(("--eval" "(setq vc-handled-backends nil org-startup-
  command-line()
  normal-top-level()
Test test-org-num/format-function condition:
    (ert-test-failed
     ((should
       (equal '...
        (org-test-with-temp-text "* H1
** H2" ... ...)))
      :form
      (equal
       ("foo" "foo")
       (#("1.1 " 0 4 ...)
         #("1 " 0 2 ...)))
      :value nil :explanation
      (list-elt 0
                (arrays-of-different-length 3 4 "foo"
                                            #("1.1 " 0 4 ...)
                                            first-mismatch-at 0))))
--8<---------------cut here---------------end--------------->8---

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: batch failure of first org-num test
  2019-01-07 19:18 batch failure of first org-num test Kyle Meyer
@ 2019-01-07 19:56 ` Kyle Meyer
  2019-01-08 11:37   ` Kaushal Modi
  0 siblings, 1 reply; 3+ messages in thread
From: Kyle Meyer @ 2019-01-07 19:56 UTC (permalink / raw)
  To: emacs-orgmode, kaushal.modi

Sorry, I just now spotted an earlier message from Kaushal that reports
the same test failure:
https://lists.gnu.org/archive/html/emacs-orgmode/2019-01/msg00112.html

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: batch failure of first org-num test
  2019-01-07 19:56 ` Kyle Meyer
@ 2019-01-08 11:37   ` Kaushal Modi
  0 siblings, 0 replies; 3+ messages in thread
From: Kaushal Modi @ 2019-01-08 11:37 UTC (permalink / raw)
  To: Kyle Meyer; +Cc: emacs-org list

[-- Attachment #1: Type: text/plain, Size: 315 bytes --]

On Mon, Jan 7, 2019, 2:56 PM Kyle Meyer <kyle@kyleam.com wrote:

> Sorry, I just now spotted an earlier message from Kaushal that reports
> the same test failure:
> https://lists.gnu.org/archive/html/emacs-orgmode/2019-01/msg00112.html


No need to be sorry. You did the debugging and even found a fix for this. :)

[-- Attachment #2: Type: text/html, Size: 755 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2019-01-08 11:38 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-01-07 19:18 batch failure of first org-num test Kyle Meyer
2019-01-07 19:56 ` Kyle Meyer
2019-01-08 11:37   ` Kaushal Modi

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).