emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Kaushal Modi <kaushal.modi@gmail.com>
To: Nicolas Goaziou <mail@nicolasgoaziou.fr>
Cc: Michael Albinus <michael.albinus@gmx.de>,
	emacs-org list <emacs-orgmode@gnu.org>
Subject: Re: 6 failing tests on master branch
Date: Fri, 09 Jun 2017 15:14:55 +0000	[thread overview]
Message-ID: <CAFyQvY1NygN-7ukiZOXvZ+jNfp0qwwaiPH+6Z9iuH38J9xadng@mail.gmail.com> (raw)
In-Reply-To: <CAFyQvY3kQARX5h7HxGgOXOxR-Tk_VyFxVfYzj7mjN2w8rn8row@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 1010 bytes --]

On Fri, Jun 9, 2017 at 10:26 AM Kaushal Modi <kaushal.modi@gmail.com> wrote:

> This one should be easy to debug since
>>
>>   (org-export-file-uri "/myself@some.where:papers/last.pdf")
>>
>> is easy to reproduce. Could you investigate where the spurious "/" comes
>> from?
>>
>
> Will do.
>

This seems to be related to a tramp file notation change on emacs master. I
don't use tramp, but I heard about it on emacs-devel.

Here is a test expression:

    (find-file-name-handler "/myself@some.where:papers/last.pdf"
'file-remote-p)

On emacs 25.2, that returns tramp-file-name-handler.
On emacs master, that returns nil.

So, on emacs 25.2, in org-export-file-uri, the (org-file-remote-p filename)
case evaluates to true. Whereas, on emacs master, the execution falls into
the default (t ..) case.

.. and thus the spurious "/".

Copying the tramp dev Michael Albinus on this for help.
@Michael How should the above find-file-name-handler arg change to support
that test file path?

Thanks.
-- 

Kaushal Modi

[-- Attachment #2: Type: text/html, Size: 1850 bytes --]

  reply	other threads:[~2017-06-09 15:15 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-08 20:33 6 failing tests on master branch Kaushal Modi
2017-06-08 21:10 ` Nicolas Goaziou
2017-06-09 14:26   ` Kaushal Modi
2017-06-09 15:14     ` Kaushal Modi [this message]
2017-06-09 16:02       ` Michael Albinus
2017-06-09 16:10         ` Kaushal Modi
2017-06-09 16:27           ` Nicolas Goaziou
2017-06-09 19:55             ` Kaushal Modi
2017-06-09 20:05               ` Nicolas Goaziou
2017-06-09 20:21                 ` Kaushal Modi
2017-06-14 14:56   ` Backward incompatible outline-invisible-p change in emacs master for Org (Was: 6 failing tests on master branch) Kaushal Modi
2017-06-14 16:03     ` Kaushal Modi
2017-06-14 17:02     ` Backward incompatible outline-invisible-p change in emacs master for Org Bastien Guerry
2017-06-14 17:18       ` Kaushal Modi
2017-06-14 20:28         ` Paul Rankin
2017-06-15  6:19           ` Bastien Guerry
2017-06-15 12:16             ` Kaushal Modi
2017-06-15 12:40               ` Bastien Guerry
2017-06-15 13:08                 ` Kaushal Modi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAFyQvY1NygN-7ukiZOXvZ+jNfp0qwwaiPH+6Z9iuH38J9xadng@mail.gmail.com \
    --to=kaushal.modi@gmail.com \
    --cc=emacs-orgmode@gnu.org \
    --cc=mail@nicolasgoaziou.fr \
    --cc=michael.albinus@gmx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).