From: Paul Rankin <hello@paulwrankin.com>
To: Kaushal Modi <kaushal.modi@gmail.com>
Cc: Bastien Guerry <bzg@gnu.org>,
emacs-org list <emacs-orgmode@gnu.org>,
Nicolas Goaziou <mail@nicolasgoaziou.fr>
Subject: Re: Backward incompatible outline-invisible-p change in emacs master for Org
Date: Thu, 15 Jun 2017 06:28:09 +1000 [thread overview]
Message-ID: <1497472089.767910.1009650952.07E5CDA4@webmail.messagingengine.com> (raw)
In-Reply-To: <CAFyQvY3SiSZKSedRyEEyBgh5QNRN1Kj_GSYNn0GGVDJS3tkFYw@mail.gmail.com>
On Thu, 15 Jun 2017, at 03:18 AM, Kaushal Modi wrote:
> On Wed, Jun 14, 2017 at 1:02 PM Bastien Guerry <bzg@gnu.org> wrote:
>
> > The question is: why this patch in the first place? Paul authored it
> > and I committed it, so I should know--but I don't. Maybe Paul know or
> > you know better?
> >
>
> I later found the reason for that commit here:
> https://debbugs.gnu.org/cgi/bugreport.cgi?bug=24073
>
> Here is the emacs -Q recipe that Paul posted on that debbugs report:
>
> 1. emacs -Q
> 2. insert ";;; heading"
> 3. M-: (outline-on-heading-p)
> => t
> 4. C-a
> 5. M-: (put-text-property (point) (1+ (point)) 'invisible 'foo)
> 6. M-; (outline-on-heading-p)
> => nil
>
> Expected results:
>
> (outline-on-heading-p)
> => t
>
> Actual results:
>
> (outline-on-heading-p)
> => nil
>
> This shows the relation between outline-on-heading-p and
> outline-invisible-p:
>
> (defun outline-on-heading-p (&optional invisible-ok)
> "Return t if point is on a (visible) heading line.
> If INVISIBLE-OK is non-nil, an invisible heading line is ok too."
> (save-excursion
> (beginning-of-line)
> (and (bolp) (or invisible-ok (not (outline-invisible-p)))
> (looking-at outline-regexp))))
>
> Basically the expectation is that a outline heading be not marked as
> "invisible" by any 'foo invisible property. Outline headings should be
> marked invisible by only 'outline invisible property.
>
> Also as the function is prefixed with "outline-", that kind of makes sense.
>
> On the other hand, in org, we need a function that returns non-nil for
> *any* invisible property. So that commit breaks org's expectation.
>
> This looks fine,
>
>
> Thanks.
>
>
> > but I'd rather revert the faulty Emacs commit if
> > it is not necessary.
> >
> > Until Paul enlighten us, I'll have a deeper look.
> >
>
> After reviewing debbugs 24073, the commit looks correct for emacs master
> and outline package. WDYT?
Glad the mystery looks like it's solved.
Btw I looped in the orgmode list back here http://lists.gnu.org/archive/html/emacs-orgmode/2016-09/msg00029.html
Thanks.
--
www.paulwrankin.com
next prev parent reply other threads:[~2017-06-14 20:28 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-08 20:33 6 failing tests on master branch Kaushal Modi
2017-06-08 21:10 ` Nicolas Goaziou
2017-06-09 14:26 ` Kaushal Modi
2017-06-09 15:14 ` Kaushal Modi
2017-06-09 16:02 ` Michael Albinus
2017-06-09 16:10 ` Kaushal Modi
2017-06-09 16:27 ` Nicolas Goaziou
2017-06-09 19:55 ` Kaushal Modi
2017-06-09 20:05 ` Nicolas Goaziou
2017-06-09 20:21 ` Kaushal Modi
2017-06-14 14:56 ` Backward incompatible outline-invisible-p change in emacs master for Org (Was: 6 failing tests on master branch) Kaushal Modi
2017-06-14 16:03 ` Kaushal Modi
2017-06-14 17:02 ` Backward incompatible outline-invisible-p change in emacs master for Org Bastien Guerry
2017-06-14 17:18 ` Kaushal Modi
2017-06-14 20:28 ` Paul Rankin [this message]
2017-06-15 6:19 ` Bastien Guerry
2017-06-15 12:16 ` Kaushal Modi
2017-06-15 12:40 ` Bastien Guerry
2017-06-15 13:08 ` Kaushal Modi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1497472089.767910.1009650952.07E5CDA4@webmail.messagingengine.com \
--to=hello@paulwrankin.com \
--cc=bzg@gnu.org \
--cc=emacs-orgmode@gnu.org \
--cc=kaushal.modi@gmail.com \
--cc=mail@nicolasgoaziou.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).